unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 38576@debbugs.gnu.org
Subject: [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading
Date: Thu, 12 Dec 2019 20:13:57 +0100	[thread overview]
Message-ID: <CAJ3okZ2SYmwZuJZARZnx7Ebigmh=usQdYCd-AEpy8PwDDoqPcg@mail.gmail.com> (raw)
In-Reply-To: <20191212100452.GE22717@zpidnp36>

Hi,

Thank you for your patch!

On Thu, 12 Dec 2019 at 13:36, Lars-Dominik Braun
<ldb@leibniz-psychology.org> wrote:

> > > @@ -12423,6 +12429,8 @@ running IRkernel session.")
> > >         ("r-evaluate" ,r-evaluate)
> > >         ("r-irdisplay" ,r-irdisplay)
> > >         ("r-jsonlite" ,r-jsonlite)
> > > +       ;; sets R_LIBS_SITE, so R can actually find this package (IRkernel)
> > > +       ("r-minimal" ,r-minimal)
> > >         ("r-pbdzmq" ,r-pbdzmq)
> > >         ("r-repr" ,r-repr)
> > >         ("r-uuid" ,r-uuid)))
> >
> > This doesn’t look right to me.  It seems wrong for any R package to
> > propagate R itself.  The R_LIBS_SITE variable is “attached” to
> > “r-minimal”, so when that is installed R will find the r-irkernel
> > package.  Am I missing something?

> If r-minimal is not installed, the kernel will simply not work and thus
> render this package useless. That’s why I would consider it a dependency.

Hum? it is true for any R package, isn't it?
I mean, all the R packages needs R to work but R is not a dependency.

We can discuss if a R package has to propagate R itself or not.
But it is not how the R packages are usually defined in Guix; AFAIU.
To stay coherent, "r-minimal" should not be propagated or I also miss
something. :-)

Currently, I usually type "guix install r r-pkg" and not "guix install r-pkg".

All the best,
simon

  reply	other threads:[~2019-12-12 19:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12  7:46 [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading Lars-Dominik Braun
2019-12-12  9:41 ` Ricardo Wurmus
2019-12-12 10:04   ` Lars-Dominik Braun
2019-12-12 19:13     ` zimoun [this message]
2019-12-19 22:47     ` Ludovic Courtès
2020-01-02  7:35       ` Lars-Dominik Braun
2020-01-02 11:43         ` Ludovic Courtès
2020-01-03 15:12           ` bug#38576: " Ludovic Courtès
2020-01-06 18:14           ` [bug#38576] " zimoun
2020-01-07 21:02           ` Roel Janssen
2020-01-07 23:01             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3okZ2SYmwZuJZARZnx7Ebigmh=usQdYCd-AEpy8PwDDoqPcg@mail.gmail.com' \
    --to=zimon.toutoune@gmail.com \
    --cc=38576@debbugs.gnu.org \
    --cc=ldb@leibniz-psychology.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).