From: "Ludovic Courtès" <ludo@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: Ricardo Wurmus <rekado@elephly.net>,
38576@debbugs.gnu.org,
Lars-Dominik Braun <ldb@leibniz-psychology.org>
Subject: [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading
Date: Wed, 08 Jan 2020 00:01:26 +0100 [thread overview]
Message-ID: <874kx6hnw9.fsf@gnu.org> (raw)
In-Reply-To: <edd8dcb27c53f00df6f1305240f2bf3a564e5765.camel@gnu.org> (Roel Janssen's message of "Tue, 07 Jan 2020 22:02:13 +0100")
Hi Roel,
Roel Janssen <roel@gnu.org> skribis:
> On Thu, 2020-01-02 at 12:43 +0100, Ludovic Courtès wrote:
>> Hi,
>>
>> Lars-Dominik Braun <ldb@leibniz-psychology.org> skribis:
>>
>> > > An argument in favor of the status quo would be that it allows users to
>> > > choose between ‘r’ and ‘r-minimal’. Is that a compelling argument?
>> > reading the documentation I thought this was possible using
>> > --with-input=r-minimal=r ?
>>
>> Yes, good point.
>>
>> > > However, if we go that route, we should arrange to not propagate
>> > > ‘r-minimal’ (it’s intrusive) and instead have ‘kernel.json’ do the right
>> > > thing.
>> > I’m not following, sorry. What do you suggest kernel.json should do?
>>
>> I was suggesting hard-coding the file name of the ‘R’ executable in
>> ‘kernel.json’, but I see you already did that in your initial patch.
>> Sorry for the confusion.
>>
>> On second thought, I think propagating R is acceptable in this case
>> because a Jupyter kernel is a thin wrapper around a programming language
>> implementation.
>>
>> Unless there are objections, I’ll apply your initial patch.
>>
>
> I'm too late, but doesn't this break the kernel for people who have the "full" R
> in their profile, and therefore expect the "full" R to be available in a Jupyter
> notebook?
Indeed, it forces ‘r-minimal’ for use in the kernel. But there are
workarounds, as Lars-Dominik suggests above.
WDYT?
Ludo’.
prev parent reply other threads:[~2020-01-07 23:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 7:46 [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading Lars-Dominik Braun
2019-12-12 9:41 ` Ricardo Wurmus
2019-12-12 10:04 ` Lars-Dominik Braun
2019-12-12 19:13 ` zimoun
2019-12-19 22:47 ` Ludovic Courtès
2020-01-02 7:35 ` Lars-Dominik Braun
2020-01-02 11:43 ` Ludovic Courtès
2020-01-03 15:12 ` bug#38576: " Ludovic Courtès
2020-01-06 18:14 ` [bug#38576] " zimoun
2020-01-07 21:02 ` Roel Janssen
2020-01-07 23:01 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kx6hnw9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=38576@debbugs.gnu.org \
--cc=ldb@leibniz-psychology.org \
--cc=rekado@elephly.net \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).