From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:42532)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifTvT-0000aK-I9
 for guix-patches@gnu.org; Thu, 12 Dec 2019 14:15:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifTvS-0007oX-GB
 for guix-patches@gnu.org; Thu, 12 Dec 2019 14:15:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:54932)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ifTvS-0007mx-BV
 for guix-patches@gnu.org; Thu, 12 Dec 2019 14:15:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ifTvS-0000PB-1W
 for guix-patches@gnu.org; Thu, 12 Dec 2019 14:15:02 -0500
Subject: [bug#38576] [PATCH] gnu: r-irkernel: Fix R kernel loading
Resent-Message-ID: <handler.38576.B38576.15761780561407@debbugs.gnu.org>
MIME-Version: 1.0
References: <20191212074613.GA11713@zpidnp36> <87wob13mpn.fsf@elephly.net>
 <20191212100452.GE22717@zpidnp36>
In-Reply-To: <20191212100452.GE22717@zpidnp36>
From: zimoun <zimon.toutoune@gmail.com>
Date: Thu, 12 Dec 2019 20:13:57 +0100
Message-ID: <CAJ3okZ2SYmwZuJZARZnx7Ebigmh=usQdYCd-AEpy8PwDDoqPcg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Cc: Ricardo Wurmus <rekado@elephly.net>, 38576@debbugs.gnu.org

Hi,

Thank you for your patch!

On Thu, 12 Dec 2019 at 13:36, Lars-Dominik Braun
<ldb@leibniz-psychology.org> wrote:

> > > @@ -12423,6 +12429,8 @@ running IRkernel session.")
> > >         ("r-evaluate" ,r-evaluate)
> > >         ("r-irdisplay" ,r-irdisplay)
> > >         ("r-jsonlite" ,r-jsonlite)
> > > +       ;; sets R_LIBS_SITE, so R can actually find this package (IRk=
ernel)
> > > +       ("r-minimal" ,r-minimal)
> > >         ("r-pbdzmq" ,r-pbdzmq)
> > >         ("r-repr" ,r-repr)
> > >         ("r-uuid" ,r-uuid)))
> >
> > This doesn=E2=80=99t look right to me.  It seems wrong for any R packag=
e to
> > propagate R itself.  The R_LIBS_SITE variable is =E2=80=9Cattached=E2=
=80=9D to
> > =E2=80=9Cr-minimal=E2=80=9D, so when that is installed R will find the =
r-irkernel
> > package.  Am I missing something?

> If r-minimal is not installed, the kernel will simply not work and thus
> render this package useless. That=E2=80=99s why I would consider it a dep=
endency.

Hum? it is true for any R package, isn't it?
I mean, all the R packages needs R to work but R is not a dependency.

We can discuss if a R package has to propagate R itself or not.
But it is not how the R packages are usually defined in Guix; AFAIU.
To stay coherent, "r-minimal" should not be propagated or I also miss
something. :-)

Currently, I usually type "guix install r r-pkg" and not "guix install r-pk=
g".

All the best,
simon