* [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) [not found] ` <CA+H0LRPnqd9AdH8C59ai74pm=1o9a92hFdJsuP-P-TasSof=SA@mail.gmail.com> @ 2018-11-02 13:31 ` Björn Höfling 2018-11-02 14:23 ` Gábor Boskovits 0 siblings, 1 reply; 4+ messages in thread From: Björn Höfling @ 2018-11-02 13:31 UTC (permalink / raw) To: Lakshmi Prasannakumar; +Cc: Gábor Boskovits, 33214 [-- Attachment #1: Type: text/plain, Size: 2361 bytes --] Hi Lakshmi, On Fri, 2 Nov 2018 18:25:49 +0530 Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote: > Sure, I'll rebase it to the current master and try to bring in the > change for commit message . > > Regards, > (For the reference, applied it on top of 7b63047c943a68717b1fc21dc078e44c2415e694 where it applies without trouble). I have some more remarks: * Could you please keep the bug-tracker on CC. In that way other people can follow the discussions and it is saved for later reference. That is especially useful if the patch gets forgotten and is only later being picked up again (though I don't think that will be the case here): 33214@debbugs.gnu.org * As Gabor already said, the period "." was missing. See other commit messages to get used to the strict rules. * License field should look like this: (license license:gpl2+))) I.e. it is prefixed by "license:". That is because in line 31 the license module was imported with that prefix: #:use-module ((guix licenses) #:prefix license:) Some package modules use this syntax to prevent namespace pollution, others not. * Did you execute `guix lint` before submitting the patch? I have found some linter complaints: /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: sentences in description should be followed by two spaces; possible infractions at 197, 389 /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: line 6671 is way too long (468 characters) * The first one just means what it says. That is because the descriptions use texinfo syntax and there are two spaces used. * The second can be solved by breaking long lines of the description before 80 characters. See how it was done in other packages above. * Homepage: gnu/packages/cran.scm:6652:0: r-weights@1.0: permanent redirect from http://cran.r-project.org/web/packages/weights to http://cran.r-project.org/web/packages/weights/ So please add a trailing "/" to the URL. Also could you use "https"? instead of just plain "http"? We use the encrypted URL wherever it is available. * I'm currently trying to build it but that looks like it takes more time than usual because substitutes are missing. If anything goes wrong, I will report back. Did you try to build the package? Thank you, Björn [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) 2018-11-02 13:31 ` [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) Björn Höfling @ 2018-11-02 14:23 ` Gábor Boskovits 2018-11-02 16:29 ` Björn Höfling 0 siblings, 1 reply; 4+ messages in thread From: Gábor Boskovits @ 2018-11-02 14:23 UTC (permalink / raw) To: Björn Höfling; +Cc: Lakshmi Prasannakumar, 33214 Björn Höfling <bjoern.hoefling@bjoernhoefling.de> ezt írta (időpont: 2018. nov. 2., P, 14:31): > > Hi Lakshmi, > > On Fri, 2 Nov 2018 18:25:49 +0530 > Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote: > > > Sure, I'll rebase it to the current master and try to bring in the > > change for commit message . > > > > Regards, > > > > (For the reference, applied it on top of > 7b63047c943a68717b1fc21dc078e44c2415e694 where it applies without trouble). > > I have some more remarks: > > * Could you please keep the bug-tracker on CC. In that way other people > can follow the discussions and it is saved for later reference. That is > especially useful if the patch gets forgotten and is only later being > picked up again (though I don't think that will be the case here): > > 33214@debbugs.gnu.org > > * As Gabor already said, the period "." was missing. See other commit > messages to get used to the strict rules. > > * License field should look like this: > > (license license:gpl2+))) > > I.e. it is prefixed by "license:". That is because in line 31 the > license module was imported with that prefix: > > #:use-module ((guix licenses) #:prefix license:) > > Some package modules use this syntax to prevent namespace pollution, > others not. > > * Did you execute `guix lint` before submitting the patch? I have > found some linter complaints: > > /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: sentences in description should be followed by two spaces; possible infractions at 197, 389 > /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: line 6671 is way too long (468 characters) > > * The first one just means what it says. That is because the > descriptions use texinfo syntax and there are two spaces used. > > * The second can be solved by breaking long lines of the description > before 80 characters. See how it was done in other packages above. > > * Homepage: > > gnu/packages/cran.scm:6652:0: r-weights@1.0: permanent redirect > from http://cran.r-project.org/web/packages/weights > to http://cran.r-project.org/web/packages/weights/ > > So please add a trailing "/" to the URL. > > Also could you use "https"? instead of just plain "http"? We use the > encrypted URL wherever it is available. > Thanks Björn. It seems that currently Lakshmi has no working guix, because of problems related to missing substiutes. > * I'm currently trying to build it but that looks like it takes more > time than usual because substitutes are missing. If anything goes > wrong, I will report back. Did you try to build the package? > > Thank you, > > Björn ^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) 2018-11-02 14:23 ` Gábor Boskovits @ 2018-11-02 16:29 ` Björn Höfling 2018-11-02 19:16 ` Lakshmi Prasannakumar 0 siblings, 1 reply; 4+ messages in thread From: Björn Höfling @ 2018-11-02 16:29 UTC (permalink / raw) To: Gábor Boskovits; +Cc: Lakshmi Prasannakumar, 33214 [-- Attachment #1: Type: text/plain, Size: 704 bytes --] Hi Lakshmi, On Fri, 2 Nov 2018 15:23:04 +0100 Gábor Boskovits <boskovits@gmail.com> wrote: > Björn Höfling <bjoern.hoefling@bjoernhoefling.de> ezt írta (időpont: > 2018. nov. 2., P, 14:31): > Thanks Björn. It seems that currently Lakshmi has no working > guix, because of problems related to missing substiutes. > > > * I'm currently trying to build it but that looks like it takes more > > time than usual because substitutes are missing. If anything goes > > wrong, I will report back. Did you try to build the package? My build is finished now and it builds correctly. Yes, due to currently missing substitutes it takes a lot of time. But it should work also. Björn [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) 2018-11-02 16:29 ` Björn Höfling @ 2018-11-02 19:16 ` Lakshmi Prasannakumar 0 siblings, 0 replies; 4+ messages in thread From: Lakshmi Prasannakumar @ 2018-11-02 19:16 UTC (permalink / raw) To: Björn Höfling; +Cc: Gábor Boskovits, 33214 [-- Attachment #1: Type: text/plain, Size: 1248 bytes --] Hi Björn and Gábor, Thank you for the comments. Since the build isn't perfect, I am trying to install GUIX in a new system with updated ubuntu version. Once done with this , I'll pull the latest repository and add the package definition to the cran.scm. Later will send across the patch file to the same bug tracker id, so that it would be in track. Regards, Lakshmi Prasannakumar Bangalore On Fri, Nov 2, 2018 at 9:59 PM Björn Höfling < bjoern.hoefling@bjoernhoefling.de> wrote: > Hi Lakshmi, > > On Fri, 2 Nov 2018 15:23:04 +0100 > Gábor Boskovits <boskovits@gmail.com> wrote: > > > Björn Höfling <bjoern.hoefling@bjoernhoefling.de> ezt írta (időpont: > > 2018. nov. 2., P, 14:31): > > > Thanks Björn. It seems that currently Lakshmi has no working > > guix, because of problems related to missing substiutes. > > > > > * I'm currently trying to build it but that looks like it takes more > > > time than usual because substitutes are missing. If anything goes > > > wrong, I will report back. Did you try to build the package? > > My build is finished now and it builds correctly. > > Yes, due to currently missing substitutes it takes a lot of time. But > it should work also. > > Björn > [-- Attachment #2: Type: text/html, Size: 3133 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-02 19:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CA+H0LRPUfE=LmSETuasan3bEjEkGPXRFoE5Qrd-9G8DYO8buTQ@mail.gmail.com>
[not found] ` <20181029212738.75de1734@alma-ubu>
[not found] ` <CA+H0LRMuXJ9Ehsf0XmpUkvYpSccb4FHaieOaJaVD55T=wExR+Q@mail.gmail.com>
[not found] ` <CAE4v=pjXFW+BKmE8=Rvto+zFX0LvKb=SFWzhuHRqcm0LLP71CA@mail.gmail.com>
[not found] ` <CA+H0LROFhPkbcarAW+QqxrX0bfZW1F+o9XEigpM43jPHpVhJUA@mail.gmail.com>
[not found] ` <CA+H0LRN=N_ZoOZYjmFYR4fQtt1pyjTuV0+udreYutJkOuLqFtQ@mail.gmail.com>
[not found] ` <CAE4v=piSd5+PN-HRh2doenC_bHG6BXmzeK3sD9W5avA-xRYSzw@mail.gmail.com>
[not found] ` <CAE4v=phejzy7KDG5P3QdmOz4-7UJb50bScn0uhcrSWpDHQoGjw@mail.gmail.com>
[not found] ` <CAE4v=pge_rd-BKs6tfkZD96=5QSrjjG21VqX+sG5SgcWCBuHVw@mail.gmail.com>
[not found] ` <CA+H0LRPq4nMAH0vdZjYcKakBCvDiFZf-C0C1JWXKHT3Ex+ZqsA@mail.gmail.com>
[not found] ` <CA+H0LRPuwTtrh2d=TD+qtmUoibmLaAPCrjSSwZ=QBZv-8+8vZA@mail.gmail.com>
[not found] ` <CAE4v=pjYyO26JxMthvUA0YPp2t2_XEpuuQaAkFU-zYuEdOLbcQ@mail.gmail.com>
[not found] ` <CAE4v=pgsDnW6RkJfVcNFXcT_yB+ptht7BGJzBT4xeR2=ETg5bQ@mail.gmail.com>
[not found] ` <CA+H0LRPnqd9AdH8C59ai74pm=1o9a92hFdJsuP-P-TasSof=SA@mail.gmail.com>
2018-11-02 13:31 ` [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) Björn Höfling
2018-11-02 14:23 ` Gábor Boskovits
2018-11-02 16:29 ` Björn Höfling
2018-11-02 19:16 ` Lakshmi Prasannakumar
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).