From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIZYY-0008Us-6A for guix-patches@gnu.org; Fri, 02 Nov 2018 09:32:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIZYS-0001ze-GJ for guix-patches@gnu.org; Fri, 02 Nov 2018 09:32:10 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gIZYQ-0001ym-Kb for guix-patches@gnu.org; Fri, 02 Nov 2018 09:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gIZYQ-0000ce-D2 for guix-patches@gnu.org; Fri, 02 Nov 2018 09:32:02 -0400 Subject: [bug#33214] Video Documentation for GNU GUIX (an Outreachy project) Resent-Message-ID: Date: Fri, 2 Nov 2018 14:31:54 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20181102143154.555e711f@alma-ubu> In-Reply-To: References: <20181029212738.75de1734@alma-ubu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/pw8C9.G_9rwK1hD647zBaZZ"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Lakshmi Prasannakumar Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits , 33214@debbugs.gnu.org --Sig_/pw8C9.G_9rwK1hD647zBaZZ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Lakshmi, On Fri, 2 Nov 2018 18:25:49 +0530 Lakshmi Prasannakumar wrote: > Sure, I'll rebase it to the current master and try to bring in the > change for commit message . >=20 > Regards, >=20 (For the reference, applied it on top of 7b63047c943a68717b1fc21dc078e44c2415e694 where it applies without trouble). I have some more remarks: * Could you please keep the bug-tracker on CC. In that way other people can follow the discussions and it is saved for later reference. That is especially useful if the patch gets forgotten and is only later being picked up again (though I don't think that will be the case here): 33214@debbugs.gnu.org * As Gabor already said, the period "." was missing. See other commit messages to get used to the strict rules. * License field should look like this: (license license:gpl2+))) I.e. it is prefixed by "license:". That is because in line 31 the license module was imported with that prefix: #:use-module ((guix licenses) #:prefix license:) Some package modules use this syntax to prevent namespace pollution, others not. * Did you execute `guix lint` before submitting the patch? I have found some linter complaints: /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: sentenc= es in description should be followed by two spaces; possible infractions at= 197, 389 /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights@1.0: line 66= 71 is way too long (468 characters) * The first one just means what it says. That is because the descriptions use texinfo syntax and there are two spaces used. * The second can be solved by breaking long lines of the description before 80 characters. See how it was done in other packages above. * Homepage: gnu/packages/cran.scm:6652:0: r-weights@1.0: permanent redirect=20 from http://cran.r-project.org/web/packages/weights=20 to http://cran.r-project.org/web/packages/weights/ So please add a trailing "/" to the URL. Also could you use "https"? instead of just plain "http"? We use the encrypted URL wherever it is available. * I'm currently trying to build it but that looks like it takes more time than usual because substitutes are missing. If anything goes wrong, I will report back. Did you try to build the package? Thank you, Bj=C3=B6rn --Sig_/pw8C9.G_9rwK1hD647zBaZZ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlvcUcsACgkQvyhstlk+X/2sbwCfROmlv+R3ukc+XLsYMP2DEkKs zncAoLZ5eXenjOn4MuaSx31G7GjiHISl =Tomt -----END PGP SIGNATURE----- --Sig_/pw8C9.G_9rwK1hD647zBaZZ--