From: Brice Waegeneire <brice@waegenei.re>
To: Brice Waegeneire <brice@waegenei.re>
Cc: Danny Milosavljevic <dannym@scratchpost.org>,
40143-close@debbugs.gnu.org,
Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Guix-patches
<guix-patches-bounces+brice+lists=waegenei.re@gnu.org>
Subject: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase.
Date: Sat, 21 Mar 2020 14:43:56 +0000 [thread overview]
Message-ID: <97f43fbba8a1b83caa53373c459a7639@waegenei.re> (raw)
In-Reply-To: <877dzdkcgv.fsf@gmail.com>
On 2020-03-21 14:29, Mathieu Othacehe wrote:
> Hello Brice,
>
>> Danny Milosavljevic <dannym@scratchpost.org> writes:
>>
>>> invoke already returns #t, so there's no technical bug.
>>>
>>> That said, maybe for clarity? Not sure...
>
> I agree with Danny and Maxim here, we already return a boolean, or
> raise an exception in case of error, so I think we are fine :)
>
> Closing this bug,
>
> Thanks,
>
> Mathieu
Looks like a forgot to reply to all, I replied to Danny that it
should be closed. I missed the RTFM sign... I didn't knew about
Maxim's link and would like to know where are we in transitioning
away from getting rid of boolean return code in phases.
prev parent reply other threads:[~2020-03-21 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 9:20 [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase Brice Waegeneire
2020-03-20 9:54 ` Danny Milosavljevic
2020-03-20 14:21 ` Maxim Cournoyer
2020-03-21 14:29 ` bug#40143: " Mathieu Othacehe
2020-03-21 14:43 ` Brice Waegeneire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97f43fbba8a1b83caa53373c459a7639@waegenei.re \
--to=brice@waegenei.re \
--cc=40143-close@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=guix-patches-bounces+brice+lists=waegenei.re@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).