From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:60854)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFfN0-0002Az-Vv
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:45:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFfMz-00015X-SZ
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:45:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41841)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFfMz-00015O-NU
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:45:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFfMz-0001N2-Kj
 for guix-patches@gnu.org; Sat, 21 Mar 2020 10:45:01 -0400
Subject: [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase.
Resent-Message-ID: <handler.40143.D40143.15848018475139@debbugs.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Sat, 21 Mar 2020 14:43:56 +0000
From: Brice Waegeneire <brice@waegenei.re>
In-Reply-To: <877dzdkcgv.fsf@gmail.com>
References: <20200320092005.22388-1-brice@waegenei.re>
 <20200320105406.42ba348b@scratchpost.org> <87blor3y5h.fsf@gmail.com>
 <877dzdkcgv.fsf@gmail.com>
Message-ID: <97f43fbba8a1b83caa53373c459a7639@waegenei.re>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: Danny Milosavljevic <dannym@scratchpost.org>, 40143-close@debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@gmail.com>, Guix-patches <guix-patches-bounces+brice+lists=waegenei.re@gnu.org>

On 2020-03-21 14:29, Mathieu Othacehe wrote:
> Hello Brice,
> 
>> Danny Milosavljevic <dannym@scratchpost.org> writes:
>> 
>>> invoke already returns #t, so there's no technical bug.
>>> 
>>> That said, maybe for clarity?  Not sure...
> 
> I agree with Danny and Maxim here, we already return a boolean, or
> raise an exception in case of error, so I think we are fine :)
> 
> Closing this bug,
> 
> Thanks,
> 
> Mathieu

Looks like a forgot to reply to all, I replied to Danny that it
should be closed. I missed the RTFM sign... I didn't knew about
Maxim's link and would like to know where are we in transitioning
away from getting rid of boolean return code in phases.