unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Brice Waegeneire <brice@waegenei.re>
Cc: Danny Milosavljevic <dannym@scratchpost.org>,
	40143-close@debbugs.gnu.org,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#40143: [PATCH] gnu: git: Return #t in install-man-pages phase.
Date: Sat, 21 Mar 2020 15:29:52 +0100	[thread overview]
Message-ID: <877dzdkcgv.fsf@gmail.com> (raw)
In-Reply-To: <87blor3y5h.fsf@gmail.com>


Hello Brice,

> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> invoke already returns #t, so there's no technical bug.
>>
>> That said, maybe for clarity?  Not sure...

I agree with Danny and Maxim here, we already return a boolean, or
raise an exception in case of error, so I think we are fine :)

Closing this bug,

Thanks,

Mathieu

  reply	other threads:[~2020-03-21 14:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  9:20 [bug#40143] [PATCH] gnu: git: Return #t in install-man-pages phase Brice Waegeneire
2020-03-20  9:54 ` Danny Milosavljevic
2020-03-20 14:21   ` Maxim Cournoyer
2020-03-21 14:29     ` Mathieu Othacehe [this message]
2020-03-21 14:43       ` Brice Waegeneire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dzdkcgv.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=40143-close@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    --cc=dannym@scratchpost.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).