From: Maxime Devos <maximedevos@telenet.be>
To: Marcel van der Boom <marcel@van-der-boom.nl>, 56766@debbugs.gnu.org
Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le
Date: Tue, 26 Jul 2022 20:01:12 +0200 [thread overview]
Message-ID: <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> (raw)
In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 940 bytes --]
On 25-07-2022 21:47, Marcel van der Boom wrote:
> + (patches
> + (if (target-ppc64le?)
> + (list (search-patch "exiv2-ppc64.patch"))))))
The second branch of the 'if' is missing -- as-is, *unspecified* is used
when (not (target-ppc64le?)), which won't work.
The 'patches' field is delayed, not thunked, so only the first
system+target it sees will take effect. This will break things if for
whatever reason you compute the derivation of the package for multiple
systems in the same process.
To solve things, I recommend:
1. Inform upstream that the test (or the code it tests) is broken on
ppc64le, such that a better test can be devised and everyone (not
only Guix) benefits,
2. and for now, modify the test file in a phase (using 'substitute*')
-- phases are thunked instead of delayed or direct, so the issue
mentioned above doesn't hold.
Greetings,
Maxime.
[-- Attachment #1.1.1.2: Type: text/html, Size: 1465 bytes --]
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-07-26 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 19:47 [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Marcel van der Boom
2022-07-26 18:01 ` Maxime Devos [this message]
2022-07-26 18:38 ` Marcel van der Boom
2022-07-26 18:55 ` Maxime Devos
2022-07-26 18:02 ` Maxime Devos
2022-07-26 19:11 ` Maxime Devos
2022-07-26 19:34 ` Marcel van der Boom
2022-07-27 7:41 ` [bug#56766] [PATCH] Adjust patch according to review Marcel van der Boom
2022-08-01 12:10 ` bug#56766: [PATCH] gnu: exiv2: Fix test failure on ppc64-le Ludovic Courtès
2022-08-01 7:32 ` [bug#56766] " Marcel van der Boom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be \
--to=maximedevos@telenet.be \
--cc=56766@debbugs.gnu.org \
--cc=marcel@van-der-boom.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).