From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YDrOKFgt4GI3mQAAbAwnHQ (envelope-from ) for ; Tue, 26 Jul 2022 20:07:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wHfWKFgt4GKjHwAAauVa8A (envelope-from ) for ; Tue, 26 Jul 2022 20:07:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C9A529A73 for ; Tue, 26 Jul 2022 20:07:20 +0200 (CEST) Received: from localhost ([::1]:35280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGOxj-0001Wt-EQ for larch@yhetil.org; Tue, 26 Jul 2022 14:07:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGOsj-0004Vw-Q9 for guix-patches@gnu.org; Tue, 26 Jul 2022 14:02:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGOsc-0006sH-6M for guix-patches@gnu.org; Tue, 26 Jul 2022 14:02:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGOsb-0001pX-TZ for guix-patches@gnu.org; Tue, 26 Jul 2022 14:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marcel van der Boom , 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.16588584776957 (code B ref 56766); Tue, 26 Jul 2022 18:02:01 +0000 Received: (at 56766) by debbugs.gnu.org; 26 Jul 2022 18:01:17 +0000 Received: from localhost ([127.0.0.1]:54348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGOrt-0001o8-Bp for submit@debbugs.gnu.org; Tue, 26 Jul 2022 14:01:17 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGOrr-0001ns-CK for 56766@debbugs.gnu.org; Tue, 26 Jul 2022 14:01:16 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by michel.telenet-ops.be with bizsmtp id zu1C2700V20ykKC06u1Drb; Tue, 26 Jul 2022 20:01:13 +0200 Message-ID: <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> Date: Tue, 26 Jul 2022 20:01:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> From: Maxime Devos In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0dNgFSNYs0s9XFblehdDbRPL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1658858473; bh=p4VPAMnq/45V09iUnalxnr8mlLYtXy6rlY/UYvTFNkc=; h=Date:To:References:From:Subject:In-Reply-To; b=I+3LeIj/U87MhOFcK+6V+4P7RWC95Oe9aYn0ADRRS4++2zpp/r5n58/umn+z2FmVu 8J4c4j32ru2HlyxC5ztR8tkTivTztlE7WhhWCk95sDBetUPZ/ulxvq1RXnkySmm7Ph IHJ73rpzIt7chimS3hLHCeMk6bJQ/b/JEgq3zVHtTi09pECYdtIe+QBI4gyhqgx75H MmnRY/Mk6iAr4h5IbC66Y4oASR3rmHbCy2BGerQNsoRZGdYQp9cVhqWiwY2bxpPrjB jLjg3WcaUfLya/DGEWS28dwY9NwwRyESxA1hBKkOEz58MS9CL7zF/YHbJe3y2Ci9eI v4mU4pqfVfA2Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658858840; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=gOtNeydV1NWV1qbbHMCDvPMBHQ5EY32J/KHT7QtAxV4=; b=tCB3ssmv3scNQhWADWJ7vgRONoXVB7XCA4kLAY5LixtsCn9Wipg/upgx/GKOdZBr5UQ8uX ZB0rl9GUXtetkFVgnVb+TXAxYK1CCIinKUO/PN6yEDs/YzoszOjvYpTX6YG6lgR3sHJ5mB 0OaUJkU7LBwBALXGAMpN3+RhEwLkSgmjsUlKZraU3U0dd4uMUsOIwIW3L4yqxvXFiV5ZAE TLZXa7dt0hJH5FrU1eijfblPGabiQJojCnW1uQxIZPBlNIxW4VXo5s3U5hjGyfPB/CHV9x q8PjsWy6JUofJfYjSRFmI1qiFZfNdPylPHiMtvq842S8fSSPhR0ZrE+h410m6g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658858840; a=rsa-sha256; cv=none; b=jBJMtP26JDsS7VkGCvxYNRfKzS1HWjmHojGGpRCMrtNOIg85DUqMrBDlwXB3xGVILoCWMg Y5KgrJ+2FjrQAlcZ1m7eythrprRdnVXqJ2VLS5DObKKiB358HETlRhe/9TtoN6H8L+VpFw yUJoEZ6NZlfD8GN0n7fYAmHv1Zk1wf4GHQN9AKLFORG3rD/UNlsyaaqejLFLcHkN8jDctj 9OQnaReGkqGImsY33+rmM6xp3qyqQk0MOiqUrArQO9vLzTi1xyIR+qJg3C1A58ZWxCpykl wYYVPmB55Dm2rTejfDVoLQZWQLeJMLr5IxIFV9S/unng1Xt9bMUgBs6cnNuasg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b="I+3LeIj/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.67 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b="I+3LeIj/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4C9A529A73 X-Spam-Score: 5.67 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4ikesXAzWrEK This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0dNgFSNYs0s9XFblehdDbRPL Content-Type: multipart/mixed; boundary="------------m8lyZbp0qOvuBPKIXi0VaeTW"; protected-headers="v1" From: Maxime Devos To: Marcel van der Boom , 56766@debbugs.gnu.org Message-ID: <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> Subject: Re: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> --------------m8lyZbp0qOvuBPKIXi0VaeTW Content-Type: multipart/mixed; boundary="------------GHUjGIMH2qMQ5fGsLIesBTgs" --------------GHUjGIMH2qMQ5fGsLIesBTgs Content-Type: multipart/alternative; boundary="------------qac42pprCZ49G4NllRfSh0zj" --------------qac42pprCZ49G4NllRfSh0zj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyNS0wNy0yMDIyIDIxOjQ3LCBNYXJjZWwgdmFuIGRlciBCb29tIHdyb3RlOg0KPiAr ICAgICAgIChwYXRjaGVzDQo+ICsgICAgICAgIChpZiAodGFyZ2V0LXBwYzY0bGU/KQ0KPiAr ICAgICAgICAgICAgKGxpc3QgKHNlYXJjaC1wYXRjaCAiZXhpdjItcHBjNjQucGF0Y2giKSkp KSkpDQoNClRoZSBzZWNvbmQgYnJhbmNoIG9mIHRoZSAnaWYnIGlzIG1pc3NpbmcgLS0gYXMt aXMsICp1bnNwZWNpZmllZCogaXMgdXNlZCANCndoZW4gKG5vdCAodGFyZ2V0LXBwYzY0bGU/ KSksIHdoaWNoIHdvbid0IHdvcmsuDQoNClRoZSAncGF0Y2hlcycgZmllbGQgaXMgZGVsYXll ZCwgbm90IHRodW5rZWQsIHNvIG9ubHkgdGhlIGZpcnN0IA0Kc3lzdGVtK3RhcmdldCBpdCBz ZWVzIHdpbGwgdGFrZSBlZmZlY3QuIFRoaXMgd2lsbCBicmVhayB0aGluZ3MgaWYgZm9yIA0K d2hhdGV2ZXIgcmVhc29uIHlvdSBjb21wdXRlIHRoZSBkZXJpdmF0aW9uIG9mIHRoZSBwYWNr YWdlIGZvciBtdWx0aXBsZSANCnN5c3RlbXMgaW4gdGhlIHNhbWUgcHJvY2Vzcy4NCg0KVG8g c29sdmUgdGhpbmdzLCBJIHJlY29tbWVuZDoNCg0KIDEuIEluZm9ybSB1cHN0cmVhbSB0aGF0 IHRoZSB0ZXN0IChvciB0aGUgY29kZSBpdCB0ZXN0cykgaXMgYnJva2VuIG9uDQogICAgcHBj NjRsZSwgc3VjaCB0aGF0IGEgYmV0dGVyIHRlc3QgY2FuIGJlIGRldmlzZWQgYW5kIGV2ZXJ5 b25lIChub3QNCiAgICBvbmx5IEd1aXgpIGJlbmVmaXRzLA0KIDIuIGFuZCBmb3Igbm93LCBt b2RpZnkgdGhlIHRlc3QgZmlsZSBpbiBhIHBoYXNlICh1c2luZyAnc3Vic3RpdHV0ZSonKQ0K ICAgIC0tIHBoYXNlcyBhcmUgdGh1bmtlZCBpbnN0ZWFkIG9mIGRlbGF5ZWQgb3IgZGlyZWN0 LCBzbyB0aGUgaXNzdWUNCiAgICBtZW50aW9uZWQgYWJvdmUgZG9lc24ndCBob2xkLg0KDQpH cmVldGluZ3MsDQpNYXhpbWUuDQoNCg== --------------qac42pprCZ49G4NllRfSh0zj Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 25-07-2022 21:47, Marcel van der Boom wrote:
+       (patches
+        (if (target-ppc64le?)
+            (list (search-patch "exiv2-ppc64.patch"))))))

The second branch of the 'if' is missing -- as-is, *unspecified* is used when (not (target-ppc64le?)), which won't work.

The 'patches' field is delayed, not thunked, so only the first system+target it sees will take effect. This will break things if for whatever reason you compute the derivation of the package for multiple systems in the same process.

To solve things, I recommend:

  1. Inform upstream that the test (or the code it tests) is broken on ppc64le, such that a better test can be devised and everyone (not only Guix) benefits,
  2. and for now, modify the test file in a phase (using 'substitute*') -- phases are thunked instead of delayed or direct, so the issue mentioned above doesn't hold.

Greetings,
Maxime.

--------------qac42pprCZ49G4NllRfSh0zj-- --------------GHUjGIMH2qMQ5fGsLIesBTgs Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------GHUjGIMH2qMQ5fGsLIesBTgs-- --------------m8lyZbp0qOvuBPKIXi0VaeTW-- --------------0dNgFSNYs0s9XFblehdDbRPL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuAr6AUDAAAAAAAKCRBJ4+4iGRcl7k8Q AP41tDvSOjumYCwFrMAgVFcKsIRuDzzXhF43Mpku3imObwEAluLxt6v0uKrATG2gCT/b4LvHxiwf TQER+lioA1cgOgs= =d2r5 -----END PGP SIGNATURE----- --------------0dNgFSNYs0s9XFblehdDbRPL--