From: Maxime Devos <maximedevos@telenet.be>
To: Marcel van der Boom <marcel@van-der-boom.nl>, 56766@debbugs.gnu.org
Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le
Date: Tue, 26 Jul 2022 21:11:16 +0200 [thread overview]
Message-ID: <4f61b4a9-a299-dc9a-c817-a74909091a6c@telenet.be> (raw)
In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 1855 bytes --]
>> 1. Inform upstream that the test (or the code it tests) is broken on
>> ppc64le, such that a better test can be devised and everyone (not
>> only Guix) benefits,
>
> This has been done. Their reply, in short: ppc64 is not on their
> supported platforms list and they delegate the fix to others.
OK, in that case ...
On 25-07-2022 21:47, Marcel van der Boom wrote:
> +--- /tests/bugfixes/github/test_CVE_2018_12265.py
> ++++ /tests/bugfixes/github/test_CVE_2018_12265.py
> +@@ -18,7 +18,6 @@
> + Warning: Directory Image, entry 0x0201: Strip 0 is outside of the data area; ignored.
> + Warning: Directory Image, entry 0x0201: Strip 7 is outside of the data area; ignored.
> + Error: Offset of directory Thumbnail, entry 0x0201 is out of bounds: Offset = 0x00000000; truncating the entry
> +-$uncaught_exception $addition_overflow_message
> + """
> + ]
> +- retval = [1]
> ++ retval = [0]
... this is your proposed fix for powerpc64le, but how do we know
whether it is correct? Is this just rewriting the test until it passes,
hiding the underlying overflow bug which even had an CVE so probably
pretty important to not hide it and actually fix it, or do we know for a
fact that on ppc64le, a retval = [0] is correct?
Maybe this is answered by:
> ppc64 and arm do not raise exception and thus output and exit code for test is different.
but I don't know if that's working around symptoms or addressing the
cause, e.g.
https://github.com/Exiv2/exiv2/issues/933#issuecomment-863333032 noticed
something on offsets -- summarised, this is not a sufficiently
convincing explanation for me.
Also, somehow this version of the package builds on Debian sid, so maybe
Debian knows more, though I'm not finding anything relevant in the
Debian package myself.
Greetings,
Maxime.
[-- Attachment #1.1.1.2: Type: text/html, Size: 2810 bytes --]
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-07-26 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 19:47 [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Marcel van der Boom
2022-07-26 18:01 ` Maxime Devos
2022-07-26 18:38 ` Marcel van der Boom
2022-07-26 18:55 ` Maxime Devos
2022-07-26 18:02 ` Maxime Devos
2022-07-26 19:11 ` Maxime Devos [this message]
2022-07-26 19:34 ` Marcel van der Boom
2022-07-27 7:41 ` [bug#56766] [PATCH] Adjust patch according to review Marcel van der Boom
2022-08-01 12:10 ` bug#56766: [PATCH] gnu: exiv2: Fix test failure on ppc64-le Ludovic Courtès
2022-08-01 7:32 ` [bug#56766] " Marcel van der Boom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f61b4a9-a299-dc9a-c817-a74909091a6c@telenet.be \
--to=maximedevos@telenet.be \
--cc=56766@debbugs.gnu.org \
--cc=marcel@van-der-boom.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).