[bug#54852] [PATCH] gnu: Add openjdk18.

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

Rostislav Svoboda schreef op wo 11-05-2022 om 17:37 [+0200]:
> > > About the labels issue: maybe "icedtea-8" could be changed to
> > > "icedtea", "openjdkN" to "openjdk" and "openjdkN:jdk" to
> > > "openjdk:jdk" at some point in the future, such that the package
> > > name
> > > matches the input label and the input alist can be changed to a
> > > package list.
> > 
> > is addressed, WDYT of (replace "openjdk" openjdk)?
> 
> ???
> Could you explain that please?
> Because to me, out of any context, (e.g. when grep-ing over the
> source
> code,) that looks like a "replace a-thing with a-thing". I.e.
> effectively, a do-nothing command.

Oops, I meant (replace "openjdk" openjdkN). Basically, whenever we now
have (native-inputs `(("openjdkN" ,openjdkN) ("openjdkN" ,openjdkN
"jdk") [... other inputs ...])), let's replace it by

  ;; In the openjdkN+1 package
  (native-inputs
    (list `(("openjdk" ,openjdkN)
            ("openjdk:jdk" ,openjdkN "jdk")
            [...])))

such that we always use the same input labels for the openjdk packages
(here, N is 9, 10, 11, 12, 13, 14, 15 or 16).

Then the the native-inputs can be simplified to (using "guix style"):

  (native-inputs
    (list openjdkN `(,openjdkN "jdk") [...]))

and further to

  (native-inputs
    (modify-inputs (package-native-inputs openjdkN)
      (replace "openjdk" openjdkN)))

which means: take the 'native-inputs' of the previous version of
'openjdk', but replace the openjdk it uses (openjdkN-1) by itself
(openjdkN).



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]