unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Rostislav Svoboda <rostislav.svoboda@gmail.com>
Cc: 54852@debbugs.gnu.org
Subject: [bug#54852] [PATCH] gnu: Add openjdk18.
Date: Tue, 10 May 2022 08:59:13 +0200	[thread overview]
Message-ID: <f7b6c91febc02d7a0cb6afc1cbce5e3df586d468.camel@telenet.be> (raw)
In-Reply-To: <CAEtmmez=WOj7KCips=LR1aiikkmAhTioDOv=oBKw7gy5-uMUkw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

Rostislav Svoboda schreef op di 10-05-2022 om 00:20 [+0200]:
> /home/bost/dev/guix/gnu/packages
> $ time guix build --check --load-path=. openjdk
> [...]
> and it looks like the warnings can be ignored

packages contains files like "base.scm" corresponding to the module
(gnu packages base).  However, now there are two (gnu packages base) --
the base from the guix you run, and the base from ./.  Additionally,
"base.scm" has a module (gnu packages base) so Guile expects it to be
located in ./gnu/package/base.scm instead.

Instead, try:

/home/bost/dev/guix
# do this inside a "guix shell -D guix" or whatever you use
# to set up a Guix development environment  
$ make && time ./pre-inst-env guix build openjdk

(also, don't do --check -- check is for verifying that the build was
reproducible, but it's a new package definition, so Guix doesn't have
anything to compare it against).

> The following graft will be made:
> [...]

Looks like Guix didn't detect the new package definition, otherwise
you'd see ‘The following packages will be build’ or the like.

> ;; I'd prefer: [...
> (delete "openjdk16:jdk")
> (append `(("openjdk17:jdk" ,openjdk17 "jdk"))))

If/when 

> About the labels issue: maybe "icedtea-8" could be changed to
> "icedtea", "openjdkN" to "openjdk" and "openjdkN:jdk" to
> "openjdk:jdk" at some point in the future, such that the package name
> matches the input label and the input alist can be changed to a
> package list.

is addressed, WDYT of (replace "openjdk" openjdk)?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-05-10  7:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 12:53 [bug#54852] [PATCH] gnu: Add openjdk18 Rostislav Svoboda
2022-04-11 13:43 ` Maxime Devos
2022-04-12 13:03   ` Rostislav Svoboda
2022-04-11 13:44 ` Maxime Devos
2022-04-12 13:24   ` Rostislav Svoboda
2022-04-21 10:27     ` Rostislav Svoboda
2022-04-21 16:38       ` Maxime Devos
2022-04-22 10:59         ` Rostislav Svoboda
2022-04-23 14:38           ` Maxime Devos
2022-04-23 15:11             ` Rostislav Svoboda
2022-04-23 16:10               ` Maxime Devos
2022-04-11 14:15 ` Julien Lepiller
2022-04-13  7:51   ` Björn Höfling
2022-05-08 16:41 ` Maxime Devos
2022-05-09 19:11 ` Maxime Devos
2022-05-09 22:20   ` Rostislav Svoboda
2022-05-10  6:59     ` Maxime Devos [this message]
2022-05-11 15:37       ` Rostislav Svoboda
2022-05-11 18:13         ` Maxime Devos
2022-05-11 18:22         ` Maxime Devos
2022-05-11 18:30         ` Maxime Devos
2022-09-27 14:17         ` bug#54852: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7b6c91febc02d7a0cb6afc1cbce5e3df586d468.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54852@debbugs.gnu.org \
    --cc=rostislav.svoboda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).