From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SB7tAfX8e2LefAEAbAwnHQ (envelope-from ) for ; Wed, 11 May 2022 20:14:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YD/SAfX8e2IFvwAA9RJhRA (envelope-from ) for ; Wed, 11 May 2022 20:14:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9AAA614F54 for ; Wed, 11 May 2022 20:14:12 +0200 (CEST) Received: from localhost ([::1]:37966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noqqh-0004T7-Nq for larch@yhetil.org; Wed, 11 May 2022 14:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noqqY-0004Sz-Fn for guix-patches@gnu.org; Wed, 11 May 2022 14:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1noqqY-0007UP-4E for guix-patches@gnu.org; Wed, 11 May 2022 14:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1noqqX-0003OK-VE for guix-patches@gnu.org; Wed, 11 May 2022 14:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54852] [PATCH] gnu: Add openjdk18. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 May 2022 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54852 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda Cc: 54852@debbugs.gnu.org Received: via spool by 54852-submit@debbugs.gnu.org id=B54852.165229279812965 (code B ref 54852); Wed, 11 May 2022 18:14:01 +0000 Received: (at 54852) by debbugs.gnu.org; 11 May 2022 18:13:18 +0000 Received: from localhost ([127.0.0.1]:38404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noqpq-0003N3-3x for submit@debbugs.gnu.org; Wed, 11 May 2022 14:13:18 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:43530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noqpn-0003Mr-C0 for 54852@debbugs.gnu.org; Wed, 11 May 2022 14:13:16 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id VWDD2700F4UW6Th06WDDRb; Wed, 11 May 2022 20:13:13 +0200 Message-ID: <8f19c4e7977c5171d68dfdea9e5991713973ca0b.camel@telenet.be> From: Maxime Devos Date: Wed, 11 May 2022 20:13:09 +0200 In-Reply-To: References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0gIcf1QwzMtf8IPqzvYG" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1652292793; bh=AcA/WCF13Zhrg5ZAZE4UN5OL6cGvbzUYXmIS3G7iWNU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=QT6zOjdj4J47X63PQ+U97BbCrfEJ58T4Fb/iD4nLixqVHe7lk+SsWJ0j91U+NNloo gxz1Y40m6boJLpA2AiBAmZBFDYc8vzHkOGxC7Mwe96dppJ/4FWsrIYbqTgmtbWkclB I2KTgF8ek/SYKyXL5k9eQ+mhSgpIZrouOhz+yXCbpOTYWY61BCbgSD/DLcBMWRxQSI t9ieTtkN/0vVAQCHgym0Ybyp5/QxW+eu7IM5PJLmaGo4roitnEMGXr59QLd3QwCPvx JLBSVjzVwvYKmEbdluXpFNaU6YzT6iSjyMzIq8RhDn/NWpyMW7x+t4l0FwlPqOhK4c 1hYxiQHsw2dVQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652292852; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AcA/WCF13Zhrg5ZAZE4UN5OL6cGvbzUYXmIS3G7iWNU=; b=qz7m5t2kJITd7l9i3DTFSPXVgJmFPrSOYI1oWe1bhVFP3SxjCCRbpRMlWia9vEgyu0+j7k eEaKM9kfJ1ss5SfDm1PwhAJINxFHMP0eIIPRclSqsKyIYV4XwC1KEPdKRCNSK6D9DbyJ79 tPTiXMTZBSXYhVNzysYpyOAkKIaqyaTytYfU9TgB/BaFMlbFSecc/MpokXLfrZpupAtKt0 HQLWis/N0uL6ZCkSRmjgIuJklkNg+qPkYIMJSGeV0QNI3id/kFAVXfJ/hA6n5+24IThmhh E83RmYbIptls2dvfErMT06VlWzd8/1fa5oyINmKHXIYcU6m1XTJU3ZrwVbFbHA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652292852; a=rsa-sha256; cv=none; b=oXAvgZHj7kIeW8IFgY02d9Z5zjmS67QaQB+8EhF+iwp7N5FmTfBH6is84qk4aDIlsOBYvf pXiz43k+QTGRAHIP9+9bckwl2tSEScFw3p67z1dpoLFQ9ufEZIUAo2vzVmJTs93oDJUtbb YvhTyXAn5IjSaYJ+QI5Tpc9q71DhEbx0xtyCU1ISSwSeA7Fz3LNa6KTawwaTwkoR/ALnGB crH6dC5rDQqnQmWRTxQ4/Maco+wqokRHVR2jltrxWBYQtZ7S0+paBKDmegrAAfb30akMJC 2eeEs9Rg1lKVjRbmjbb7qVK/gHeKywdk0S5yjvAebDpstiujKJrcZNgkMeBzjQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=QT6zOjdj; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=QT6zOjdj; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9AAA614F54 X-Spam-Score: 3.89 X-Migadu-Scanner: scn1.migadu.com X-TUID: gSJqojinr6YV --=-0gIcf1QwzMtf8IPqzvYG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Rostislav Svoboda schreef op wo 11-05-2022 om 17:37 [+0200]: > > > About the labels issue: maybe "icedtea-8" could be changed to > > > "icedtea", "openjdkN" to "openjdk" and "openjdkN:jdk" to > > > "openjdk:jdk" at some point in the future, such that the package > > > name > > > matches the input label and the input alist can be changed to a > > > package list. > >=20 > > is addressed, WDYT of (replace "openjdk" openjdk)? >=20 > ??? > Could you explain that please? > Because to me, out of any context, (e.g. when grep-ing over the > source > code,) that looks like a "replace a-thing with a-thing". I.e. > effectively, a do-nothing command. Oops, I meant (replace "openjdk" openjdkN). Basically, whenever we now have (native-inputs `(("openjdkN" ,openjdkN) ("openjdkN" ,openjdkN "jdk") [... other inputs ...])), let's replace it by ;; In the openjdkN+1 package (native-inputs (list `(("openjdk" ,openjdkN) ("openjdk:jdk" ,openjdkN "jdk") [...]))) such that we always use the same input labels for the openjdk packages (here, N is 9, 10, 11, 12, 13, 14, 15 or 16). Then the the native-inputs can be simplified to (using "guix style"): (native-inputs (list openjdkN `(,openjdkN "jdk") [...])) and further to (native-inputs (modify-inputs (package-native-inputs openjdkN) (replace "openjdk" openjdkN))) which means: take the 'native-inputs' of the previous version of 'openjdk', but replace the openjdk it uses (openjdkN-1) by itself (openjdkN). --=-0gIcf1QwzMtf8IPqzvYG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnv8tRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lYiAQCXwoLnno35pCBWSrGGm8Aflf22 dLjNycauHd7i19/C7gD/Y8Smhw/m62AITih6nVPAs1tP0SUkKcEuAm8i09Bb5Qc= =KVv3 -----END PGP SIGNATURE----- --=-0gIcf1QwzMtf8IPqzvYG--