unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: 37886@debbugs.gnu.org
Subject: [bug#37886] [PATCH] gnu: Add ipcalc.
Date: Thu, 24 Oct 2019 17:12:37 +0200	[thread overview]
Message-ID: <87zhhqyy6y.fsf@gmail.com> (raw)
In-Reply-To: <a44c1913-9030-1c1b-879c-981708b6bdc1@danielschaefer.me>


Hello Daniel,

> here's my first patch to guix - please let me know whether everything's okay.
> It adds the ipcalc package which can calculate IP ranges. Example:

Welcome to Guix :) This first patch looks fine, I just have two remarks.

> new file mode 100644
> index 0000000000..5f83389b25
> --- /dev/null
> +++ b/gnu/packages/ipcalc.scm

I think you can use the existing networking.scm for this tool.

> +    (description "ipcalc takes an IP address and netmask and calculates the
> +                 resulting broadcast, network, Cisco wildcard mask, and host
> +                 range.  By giving a second netmask, you can design subnets and
> +                 supernets.  It is also intended to be a teaching tool and
> +                 presents the subnetting results as easy-to-understand binary
> +                 values.")

The indentation is not correct here. You can use M-q if you are using
emacs or indent.el script otherwise (see:
https://guix.gnu.org/manual/en/html_node/Formatting-Code.html).

Can you please send an updated patch?

Thanks,

Mathieu

  reply	other threads:[~2019-10-24 15:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 13:44 [bug#37886] [PATCH] gnu: Add ipcalc Daniel Schäfer
2019-10-24 15:12 ` Mathieu Othacehe [this message]
2019-11-25 23:42   ` Ludovic Courtès
2019-12-01 16:32     ` Daniel Schäfer
2019-12-02  8:10       ` bug#37886: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhhqyy6y.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=37886@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).