From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:45841)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iNenT-0000Ml-VP
 for guix-patches@gnu.org; Thu, 24 Oct 2019 11:13:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iNenP-0007wl-3I
 for guix-patches@gnu.org; Thu, 24 Oct 2019 11:13:07 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:56189)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iNenO-0007wc-W0
 for guix-patches@gnu.org; Thu, 24 Oct 2019 11:13:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iNenO-0001fY-PW
 for guix-patches@gnu.org; Thu, 24 Oct 2019 11:13:02 -0400
Subject: [bug#37886] [PATCH] gnu: Add ipcalc.
Resent-Message-ID: <handler.37886.B37886.15719299736394@debbugs.gnu.org>
References: <a44c1913-9030-1c1b-879c-981708b6bdc1@danielschaefer.me>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <a44c1913-9030-1c1b-879c-981708b6bdc1@danielschaefer.me>
Date: Thu, 24 Oct 2019 17:12:37 +0200
Message-ID: <87zhhqyy6y.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 37886@debbugs.gnu.org


Hello Daniel,

> here's my first patch to guix - please let me know whether everything's okay.
> It adds the ipcalc package which can calculate IP ranges. Example:

Welcome to Guix :) This first patch looks fine, I just have two remarks.

> new file mode 100644
> index 0000000000..5f83389b25
> --- /dev/null
> +++ b/gnu/packages/ipcalc.scm

I think you can use the existing networking.scm for this tool.

> +    (description "ipcalc takes an IP address and netmask and calculates the
> +                 resulting broadcast, network, Cisco wildcard mask, and host
> +                 range.  By giving a second netmask, you can design subnets and
> +                 supernets.  It is also intended to be a teaching tool and
> +                 presents the subnetting results as easy-to-understand binary
> +                 values.")

The indentation is not correct here. You can use M-q if you are using
emacs or indent.el script otherwise (see:
https://guix.gnu.org/manual/en/html_node/Formatting-Code.html).

Can you please send an updated patch?

Thanks,

Mathieu