From: "Ludovic Courtès" <ludo@gnu.org>
To: "Daniel Schäfer" <git@danielschaefer.me>
Cc: 37886@debbugs.gnu.org, Mathieu Othacehe <m.othacehe@gmail.com>
Subject: [bug#37886] [PATCH] gnu: Add ipcalc.
Date: Tue, 26 Nov 2019 00:42:32 +0100 [thread overview]
Message-ID: <87a78jttef.fsf@gnu.org> (raw)
In-Reply-To: <87zhhqyy6y.fsf@gmail.com> (Mathieu Othacehe's message of "Thu, 24 Oct 2019 17:12:37 +0200")
Hello Daniel,
Did you have a chance to look into the suggestions Mathieu made?
See <https://issues.guix.gnu.org/issue/37886>.
Thanks in advance! :-)
Ludo’.
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> Hello Daniel,
>
>> here's my first patch to guix - please let me know whether everything's okay.
>> It adds the ipcalc package which can calculate IP ranges. Example:
>
> Welcome to Guix :) This first patch looks fine, I just have two remarks.
>
>> new file mode 100644
>> index 0000000000..5f83389b25
>> --- /dev/null
>> +++ b/gnu/packages/ipcalc.scm
>
> I think you can use the existing networking.scm for this tool.
>
>> + (description "ipcalc takes an IP address and netmask and calculates the
>> + resulting broadcast, network, Cisco wildcard mask, and host
>> + range. By giving a second netmask, you can design subnets and
>> + supernets. It is also intended to be a teaching tool and
>> + presents the subnetting results as easy-to-understand binary
>> + values.")
>
> The indentation is not correct here. You can use M-q if you are using
> emacs or indent.el script otherwise (see:
> https://guix.gnu.org/manual/en/html_node/Formatting-Code.html).
>
> Can you please send an updated patch?
>
> Thanks,
>
> Mathieu
next prev parent reply other threads:[~2019-11-25 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:44 [bug#37886] [PATCH] gnu: Add ipcalc Daniel Schäfer
2019-10-24 15:12 ` Mathieu Othacehe
2019-11-25 23:42 ` Ludovic Courtès [this message]
2019-12-01 16:32 ` Daniel Schäfer
2019-12-02 8:10 ` bug#37886: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a78jttef.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37886@debbugs.gnu.org \
--cc=git@danielschaefer.me \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).