From: Marius Bakke <mbakke@fastmail.com>
To: David Wilson <david@daviwil.com>, 39306@debbugs.gnu.org
Subject: [bug#39306] [PATCH] gnu: Add xsettingsd.
Date: Thu, 30 Jan 2020 13:14:59 +0100 [thread overview]
Message-ID: <87zhe5nnss.fsf@devup.no> (raw)
In-Reply-To: <87r1zlvymv.fsf@daviwil.com>
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
David Wilson <david@daviwil.com> writes:
> * gnu/packages/wm.scm (xsettingsd): New variable.
I wonder if xdisorg.scm is better suited for this package, as it seems
mostly unrelated to window management. WDYT?
[...]
> + #:tests? #f ;; Tests require Google's gtest framework
gtest is provided by the 'googletest' package. Can you try adding it?
Also, for margin comments, we only use one ';', without capitalizing the
comment.
Other than that LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-01-30 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 13:04 [bug#39306] [PATCH] gnu: Add xsettingsd David Wilson
2020-01-30 12:14 ` Marius Bakke [this message]
2020-01-30 14:20 ` David Wilson
2020-01-30 14:46 ` Marius Bakke
2020-01-30 16:01 ` David Wilson
2020-01-30 16:14 ` Marius Bakke
2020-01-31 13:57 ` bug#39306: " David Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhe5nnss.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=39306@debbugs.gnu.org \
--cc=david@daviwil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).