From: Marius Bakke <mbakke@fastmail.com>
To: David Wilson <david@daviwil.com>
Cc: 39306@debbugs.gnu.org
Subject: [bug#39306] [PATCH] gnu: Add xsettingsd.
Date: Thu, 30 Jan 2020 17:14:00 +0100 [thread overview]
Message-ID: <87d0b0orav.fsf@devup.no> (raw)
In-Reply-To: <87k1596ii6.fsf@daviwil.com>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
David Wilson <david@daviwil.com> writes:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> It is definitively OK to disable warnings coming from dependencies. In
>> fact, that is what we are supposed to do, and used to do until the
>> switch to GCC 7.
>>
>> To clarify, when we switched to GCC 7, its search paths were changed
>> from C{,PLUS}_INCLUDE_PATH to CPATH. The only[*] difference between
>> these search paths is that headers found on the former are treated as
>> "system headers", which disables warnings.
>>
>> [*] Besides the fact that GCC 6 and later is very picky about the order
>> of entries in C_INCLUDE_PATH, which is why we had to switch; see
>> <https://issues.guix.gnu.org/issue/30756> for details.
>
> Thanks for the background, that was helpful! I've been out of the loop
> on GCC changes for a while so it's good to know that this happened.
>
> I've made the suggested changes to the summary and description, attached
> the updated patch.
Excellent, LGTM!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-01-30 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 13:04 [bug#39306] [PATCH] gnu: Add xsettingsd David Wilson
2020-01-30 12:14 ` Marius Bakke
2020-01-30 14:20 ` David Wilson
2020-01-30 14:46 ` Marius Bakke
2020-01-30 16:01 ` David Wilson
2020-01-30 16:14 ` Marius Bakke [this message]
2020-01-31 13:57 ` bug#39306: " David Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0b0orav.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=39306@debbugs.gnu.org \
--cc=david@daviwil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).