From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:49064)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ix8jr-0006t3-1Y
 for guix-patches@gnu.org; Thu, 30 Jan 2020 07:16:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ix8jq-0008Pk-6e
 for guix-patches@gnu.org; Thu, 30 Jan 2020 07:16:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57278)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ix8jq-0008Pe-2Z
 for guix-patches@gnu.org; Thu, 30 Jan 2020 07:16:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ix8jp-0000Xu-R8
 for guix-patches@gnu.org; Thu, 30 Jan 2020 07:16:01 -0500
Subject: [bug#39306] [PATCH] gnu: Add xsettingsd.
Resent-Message-ID: <handler.39306.B39306.15803865102028@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <87r1zlvymv.fsf@daviwil.com>
References: <87r1zlvymv.fsf@daviwil.com>
Date: Thu, 30 Jan 2020 13:14:59 +0100
Message-ID: <87zhe5nnss.fsf@devup.no>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: David Wilson <david@daviwil.com>, 39306@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

David Wilson <david@daviwil.com> writes:

> * gnu/packages/wm.scm (xsettingsd): New variable.

I wonder if xdisorg.scm is better suited for this package, as it seems
mostly unrelated to window management.  WDYT?

[...]

> +       #:tests? #f ;; Tests require Google's gtest framework

gtest is provided by the 'googletest' package.  Can you try adding it?

Also, for margin comments, we only use one ';', without capitalizing the
comment.

Other than that LGTM.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl4yyMQACgkQoqBt8qM6
VPqqbQf/aMc0SzTQq6bK61b9Sk1Y9C3e1r3kHHceZOcsciK0G5QorOCg7JkVi/si
WV+rOCxm8fB8/dvFd2lyQmWvy5dBvUIJXjYE6jwzgUtIReQpBHn8h+UGJvbN0suu
2ois6mL1EFnV6fmnUEmgN6bmV4O7MwztNcCJhUYE8L9+oIfMhlKDdMCj8XDVCz8c
TYk0AOYaEw1pb8ge3MAhZsqNYNVoNrf3BEfSWqog3tNMcsXDIUuPjnpw/5/d1O/E
B3hCMnpMXXJc0dsGhDMvVhvh/PA6UC7XPJ9EfTjCJoyPamy59LOomijnCSPGbKJ8
XiCVjnSmUiIKISMVRwB0yitQVNR1kg==
=d4bw
-----END PGP SIGNATURE-----
--=-=-=--