unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Ekaitz Zarraga <ekaitz@elenq.tech>
Cc: "40102\\@debbugs.gnu.org" <40102-done@debbugs.gnu.org>,
	Leo Prikler <leo.prikler@student.tugraz.at>
Subject: bug#40102: [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Sat, 21 Mar 2020 20:23:20 +0100	[thread overview]
Message-ID: <87y2rt5x7b.fsf@devup.no> (raw)
In-Reply-To: <AfbWxtOJaB86st91o0f6zA6uMBnHbUrirJKdjFVApSxoTaCVAkcmXNpB7rA1ChnAJ-3cC59q9xvWwVgrXxKao3onz-iE8wPzOSbOOhy1imc=@elenq.tech>

[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]

Ekaitz Zarraga <ekaitz@elenq.tech> writes:

>> Indentation is off here. If you are not using Emacs there is a script
>> that can help with indentation, see "Formatting Code" in the Guix manual.
>
> I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't
> work very well sometimes.

In that case, please run ./etc/indent-code.el before submitting
patches to lessen the burden on committers.  I've fixed the indentation
locally by running C-M-q in Emacs.

>>
>> Can you send an updated patch?
>>
>
> Here it comes:

Thanks!  Please add it as an attachment next time so the commit message
is preserved (or send the whole patch directly with 'git send-email').

Also, './pre-inst-env guix lint gnome-shell-extension-topicons-redux'
reported these issues:

gnu/packages/gnome-xyz.scm:155:5: gnome-shell-extension-topicons-redux@6: the source file name should contain the package name
gnu/packages/gnome-xyz.scm:181:14: gnome-shell-extension-topicons-redux@6: no period allowed at the end of the synopsis

I've fixed these locally too, sorry for missing them in the first
review.

Finally I edited the commit message so it follows our conventions.
Pushed in e7c7912573111d5e86f3e3012a6edab948f7b302.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-03-21 19:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-17 12:58 [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Ekaitz Zarraga
2020-03-17 16:49 ` Leo Prikler
2020-03-17 16:55   ` Ekaitz Zarraga
2020-03-20 17:53     ` Marius Bakke
2020-03-20 19:34       ` Ekaitz Zarraga
2020-03-21 19:23         ` Marius Bakke [this message]
2020-03-21 19:34           ` Ekaitz Zarraga
2020-03-21 19:38             ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2rt5x7b.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=40102-done@debbugs.gnu.org \
    --cc=ekaitz@elenq.tech \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).