From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:41263) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFjj1-00047p-BW for guix-patches@gnu.org; Sat, 21 Mar 2020 15:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFjj0-0004Rb-C2 for guix-patches@gnu.org; Sat, 21 Mar 2020 15:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFjj0-0004RV-8c for guix-patches@gnu.org; Sat, 21 Mar 2020 15:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jFjj0-0000zM-62 for guix-patches@gnu.org; Sat, 21 Mar 2020 15:24:02 -0400 Subject: bug#40102: [PATCH] gnu packages gnome-xyz: Add topicons-redux Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: References: <87fte29al1.fsf@devup.no> Date: Sat, 21 Mar 2020 20:23:20 +0100 Message-ID: <87y2rt5x7b.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ekaitz Zarraga Cc: "40102\\@debbugs.gnu.org" <40102-done@debbugs.gnu.org>, Leo Prikler --=-=-= Content-Type: text/plain Ekaitz Zarraga writes: >> Indentation is off here. If you are not using Emacs there is a script >> that can help with indentation, see "Formatting Code" in the Guix manual. > > I'm using Vim with Vim paredit and it's own Sheme filetype, but it doesn't > work very well sometimes. In that case, please run ./etc/indent-code.el before submitting patches to lessen the burden on committers. I've fixed the indentation locally by running C-M-q in Emacs. >> >> Can you send an updated patch? >> > > Here it comes: Thanks! Please add it as an attachment next time so the commit message is preserved (or send the whole patch directly with 'git send-email'). Also, './pre-inst-env guix lint gnome-shell-extension-topicons-redux' reported these issues: gnu/packages/gnome-xyz.scm:155:5: gnome-shell-extension-topicons-redux@6: the source file name should contain the package name gnu/packages/gnome-xyz.scm:181:14: gnome-shell-extension-topicons-redux@6: no period allowed at the end of the synopsis I've fixed these locally too, sorry for missing them in the first review. Finally I edited the commit message so it follows our conventions. Pushed in e7c7912573111d5e86f3e3012a6edab948f7b302. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl52aakACgkQoqBt8qM6 VPrerAgArH0SVw+wCQOo+OUbieRcPuzcIXsHJlhcBZR1aPCVF4D9dB3kGJhYkq1Q m7SHr2syQo33UYUiP2LMmeDAenFK+WCITTkWdKihQ8xc9t+morT3IcM9NK1RSP7C e5sdzgZAkZ4Fasu7h9Ja6fCQG8bnOj2F4sjKtXWti0lj0s9LsnvDKvLSHUhbrY3F 9krw8VsNzCgQSzdoYjl8Suq0BTzJMAY9J+GEFeTjrU4fPgIJ2zURnJOZ02azCFgy ndM7GlSQ4/mSYmHWho4rGpaAcweuXH3NRj1M0rZdYC5NwPCgZf/MBO29rg/Gt3wv ocPe0cQvK28uiEiHmz/+bxD/j6Q4iQ== =VO69 -----END PGP SIGNATURE----- --=-=-=--