From: Marius Bakke <mbakke@fastmail.com>
To: Ekaitz Zarraga <ekaitz@elenq.tech>,
Leo Prikler <leo.prikler@student.tugraz.at>
Cc: "40102@debbugs.gnu.org" <40102@debbugs.gnu.org>
Subject: [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux
Date: Fri, 20 Mar 2020 18:53:46 +0100 [thread overview]
Message-ID: <87fte29al1.fsf@devup.no> (raw)
In-Reply-To: <jxwfI4XONO2CyyrY3UJHHq8_WLo74QEA_j4O2AqjC-dTnXe6ViWiIJctAJjvMY8n_doI8hoDerTJ98kip7GyJ47tXi_XMEdtegymVZfGlSc=@elenq.tech>
[-- Attachment #1: Type: text/plain, Size: 2900 bytes --]
Ekaitz Zarraga <ekaitz@elenq.tech> writes:
> From 4bbe7c5061a04d07ad9b85ff63d32379f34f8dc8 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Tue, 17 Mar 2020 13:54:24 +0100
> Subject: [PATCH] gnu packages gnome-xyz: Add topicons-redux
[...]
> +(define-public gnome-shell-extension-topicons-redux
> + (package
> + (name "gnome-shell-extension-topicons-redux")
> + (version "6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri
> + (string-append
> + "https://gitlab.com/pop-planet/TopIcons-Redux/-/archive/"
> + version "/TopIcons-Redux-" version ".tar.gz"))
Such "autogenerated" tarballs from GitLab and GitHub are prone to
getting re-created with different time stamps, breaking the checksum.
Can you adjust this package to use git-fetch instead of url-fetch?
[...]
> + (arguments
> + `(#:tests? #f
Why are tests disabled? Please leave a comment.
> + #:phases
> + (modify-phases
> + %standard-phases
> + (delete 'configure)
> + (delete 'build)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (invoke "make"
> + "install"
> + (string-append
> + "INSTALL_PATH="
> + out
> + "/share/gnome-shell/extensions"))))))))
Indentation is off here. If you are not using Emacs there is a script
that can help with indentation, see "Formatting Code" in the Guix manual.
> +
> + (home-page
> + "https://gitlab.com/pop-planet/TopIcons-Redux/")
The line break here is not necessary.
> + (synopsis "Displays legacy tray icons in the GNOME Shell top panel.
> +Rewritten fork of TopIcons Plus.")
Please keep synopsis to single sentences. The second sentence can be
removed IMO.
> + (description "Many applications, such as chat clients, downloaders, and
> +some media players, are meant to run long-term in the background even after you
> +close their window. These applications remain accessible by adding an icon to
> +the GNOME Shell Legacy Tray. However, the Legacy Tray was removed in GNOME
> +3.26. TopIcons Redux brings those icons back into the top panel so that it's
> +easier to keep track of apps running in the
> +backround.")
'guix lint gnome-shell-extension-topicons-redux' will warn that
sentences should be separated by two spaces. Can you adjust accordingly?
> + (license license:gpl2)))
Is the license really GPL2 only? Unless the source code says explicitly
"GPL2 only", this should probably be "gpl2+", i.e. "GPL2 or any later
version".
Can you send an updated patch?
TIA!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-03-20 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 12:58 [bug#40102] [PATCH] gnu packages gnome-xyz: Add topicons-redux Ekaitz Zarraga
2020-03-17 16:49 ` Leo Prikler
2020-03-17 16:55 ` Ekaitz Zarraga
2020-03-20 17:53 ` Marius Bakke [this message]
2020-03-20 19:34 ` Ekaitz Zarraga
2020-03-21 19:23 ` bug#40102: " Marius Bakke
2020-03-21 19:34 ` [bug#40102] " Ekaitz Zarraga
2020-03-21 19:38 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fte29al1.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=40102@debbugs.gnu.org \
--cc=ekaitz@elenq.tech \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).