From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 46043@debbugs.gnu.org
Subject: [bug#46043] [PATCH] Allow booting with custom shepherd package (fixed)
Date: Thu, 28 Jan 2021 00:15:51 +0100 [thread overview]
Message-ID: <87y2germxk.fsf@gnu.org> (raw)
In-Reply-To: <e0610ac55cbc14b03744f9beab5fbf0b90f4ea2f.camel@telenet.be> (Maxime Devos's message of "Wed, 27 Jan 2021 14:24:58 +0100")
Maxime Devos <maximedevos@telenet.be> skribis:
> From 1b1e49f4aad95b766126fadd4166acf5ab6fbd31 Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos@telenet.be>
> Date: Fri, 22 Jan 2021 20:06:55 +0100
> Subject: [PATCH] services: shepherd: allow custom 'shepherd' package
>
> * gnu/services/shepherd.scm
> (<shepherd-configuration>): New record.
> (shepherd-boot-gexp, shepherd-root-service-type): Use it.
> (scm->go, shepherd-configuration-file): Allow passing custom
> shepherd package.
> * doc/guix.texi (Shepherd Services). Document it.
Oops, I spoke too fast: “make check-system TESTS=basic” shows one
problem, which stems from this:
--8<---------------cut here---------------start------------->8---
(define (operating-system-shepherd-service-names os)
"Return the list of Shepherd service names for OS."
(append-map shepherd-service-provision
(service-value
(fold-services (operating-system-services os)
#:target-type
shepherd-root-service-type))))
--8<---------------cut here---------------end--------------->8---
This procedure needs to be adjusted because the value of
‘shepherd-root-service-type’ instances is no longer a list of
<shepherd-service>.
I suspect ‘guix system search’ and ‘guix system shepherd-graph’ are
affected as well, though I didn’t check (“make check” should catch it, I
think.)
Could you take a look?
TIA,
Ludo’.
next prev parent reply other threads:[~2021-01-27 23:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 19:57 [bug#46043] [PATCH] Allow booting with custom shepherd package (fixed) Maxime Devos
2021-01-23 8:25 ` Leo Prikler
2021-01-23 15:11 ` Maxime Devos
2021-01-23 15:25 ` Leo Prikler
2021-01-25 8:48 ` Maxime Devos
2021-01-26 20:49 ` Ludovic Courtès
2021-01-27 13:24 ` Maxime Devos
2021-01-27 23:09 ` bug#46043: " Ludovic Courtès
2021-01-27 23:15 ` Ludovic Courtès [this message]
2021-01-28 8:20 ` [bug#46043] " Maxime Devos
2021-01-28 13:18 ` Ludovic Courtès
2021-01-28 16:32 ` Maxime Devos
2021-01-30 14:36 ` bug#46043: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2germxk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=46043@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).