From: Maxime Devos <maximedevos@telenet.be>
To: Leo Prikler <leo.prikler@student.tugraz.at>, 46043@debbugs.gnu.org
Subject: [bug#46043] [PATCH] Allow booting with custom shepherd package (fixed)
Date: Sat, 23 Jan 2021 16:11:52 +0100 [thread overview]
Message-ID: <733adeb431a34b153e580172ae865836966d789b.camel@telenet.be> (raw)
In-Reply-To: <ee2e799f378be5d6ff197c37a5d35549e0a2f563.camel@student.tugraz.at>
[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]
Hi Leo,
On Sat, 2021-01-23 at 09:25 +0100, Leo Prikler wrote:
> Hi Maxime,
>
> Am Freitag, den 22.01.2021, 20:57 +0100 schrieb Maxime Devos:
> > (compose concatenate)
> > - (extend append)
> > + (extend (lambda (config extra-services)
> > + (shepherd-configuration
> > + (inherit config)
> > + (services (append (shepherd-configuration-services
> > config)
> > + extra-services)))))
> I think you should also patch compose or drop it. I sadly don't know,
> what impact that would have, but IIUC you should only spawn one
> shepherd-root-service anyway.
Only one shepherd-root-service-type should be spawned, correct.
In practice, this means you'll need to use a construct like this
(if I didn't make any errors):
(modify-services %base-services
(shepherd-root-service-type c =>
(shepherd-configuration
(inherit c)
(shepherd a-custom-shepherd))))
For clarification: shepherd services should be added
via the service-extension mechanism, not by
manually changing the 'services' field
(though the latter is a possibility now).
About compose and concatenate: I think it is correct as-is.
If compose is dropped, then shepherd-root-service-type wouldn't be
extensible anymore. I don't see how it could be patched
in a way that makes sense.
Compare with udev-service-type as described in the manual,
which follows the same structure.
Regards,
Maxime
--
Maxime Devos <maximedevos@telenet.be>
PGP Key: C1F3 3EE2 0C52 8FDB 7DD7 011F 49E3 EE22 1917 25EE
Freenode handle: mdevos
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-01-23 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 19:57 [bug#46043] [PATCH] Allow booting with custom shepherd package (fixed) Maxime Devos
2021-01-23 8:25 ` Leo Prikler
2021-01-23 15:11 ` Maxime Devos [this message]
2021-01-23 15:25 ` Leo Prikler
2021-01-25 8:48 ` Maxime Devos
2021-01-26 20:49 ` Ludovic Courtès
2021-01-27 13:24 ` Maxime Devos
2021-01-27 23:09 ` bug#46043: " Ludovic Courtès
2021-01-27 23:15 ` [bug#46043] " Ludovic Courtès
2021-01-28 8:20 ` Maxime Devos
2021-01-28 13:18 ` Ludovic Courtès
2021-01-28 16:32 ` Maxime Devos
2021-01-30 14:36 ` bug#46043: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=733adeb431a34b153e580172ae865836966d789b.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=46043@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).