From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 46043@debbugs.gnu.org
Subject: [bug#46043] [PATCH] Allow booting with custom shepherd package (fixed)
Date: Tue, 26 Jan 2021 21:49:57 +0100 [thread overview]
Message-ID: <875z3jzami.fsf_-_@gnu.org> (raw)
In-Reply-To: <97fca7da3cf4fd0ff5aa554bc3ec95431f85e530.camel@telenet.be> (Maxime Devos's message of "Mon, 25 Jan 2021 09:48:36 +0100")
Hi Maxime,
Maxime Devos <maximedevos@telenet.be> skribis:
> Version 2 of the patch is attached. This version also uses
> the custom package for /run/current-system/profile/bin/shepherd.
>
> From b3102f72cd66dee4442596d89e29900b8215e1be Mon Sep 17 00:00:00 2001
> From: Maxime Devos <maximedevos@telenet.be>
> Date: Fri, 22 Jan 2021 20:06:55 +0100
> Subject: [PATCH] services: shepherd: allow custom 'shepherd' package
>
> * gnu/services/shepherd.scm
> (<shepherd-configuration>): New record.
> (shepherd-boot-gexp, shepherd-root-service-type): Use it.
> (scm->go, shepherd-configuration-file): Allow passing custom
> shepherd package.
> * doc/guix.texi (Shepherd Services). Document it.
Nice! Overall LGTM. Nitpicking:
> shepherd services (@pxref{Service Types and Services}, for an example).
> -Each extension must pass a list of @code{<shepherd-service>}.
> +Each extension must pass a list of @code{<shepherd-service>}. Its
Please leave two spaces after end-of-sentence periods.
> +value must be a @code{shepherd-configuration}, as described below:
End with period rather than colon.
> +@deftp {Data Type} shepherd-configuration
> +This data type represents shepherd's configuration.
s/shepherd/the Shepherd/ (referring to the software).
> +@table @code
> +@item shepherd (default: @code{shepherd})
> +The shepherd package to use.
“Shepherd” (capitalized).
> +(define* (scm->go file #:key (shepherd shepherd))
[...]
> +(define* (shepherd-configuration-file services #:key (shepherd shepherd))
I’d made the second argument compulsory instead of a keyword parameter.
That’s all. Could you send an updated patch?
Thanks for addressing this longstanding shortcoming!
Ludo’.
next prev parent reply other threads:[~2021-01-26 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 19:57 [bug#46043] [PATCH] Allow booting with custom shepherd package (fixed) Maxime Devos
2021-01-23 8:25 ` Leo Prikler
2021-01-23 15:11 ` Maxime Devos
2021-01-23 15:25 ` Leo Prikler
2021-01-25 8:48 ` Maxime Devos
2021-01-26 20:49 ` Ludovic Courtès [this message]
2021-01-27 13:24 ` Maxime Devos
2021-01-27 23:09 ` bug#46043: " Ludovic Courtès
2021-01-27 23:15 ` [bug#46043] " Ludovic Courtès
2021-01-28 8:20 ` Maxime Devos
2021-01-28 13:18 ` Ludovic Courtès
2021-01-28 16:32 ` Maxime Devos
2021-01-30 14:36 ` bug#46043: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z3jzami.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=46043@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).