From: Tobias Geerinckx-Rice <somebody@not-sent-or-endorsed-by.tobias.gr>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33575@debbugs.gnu.org
Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted.
Date: Tue, 04 Dec 2018 10:13:14 +0100 [thread overview]
Message-ID: <87woopk639.fsf@nckx> (raw)
In-Reply-To: <87y3967n3z.fsf@gnu.org>
Ludo', Arun,
Ludovic Courtès wrote:
>> + ;; Emit a warning if inputs, native inputs or propagated
>> inputs
>> of PACKAGE
>> + ;; are not lexicographically ordered.
>
> It's something we rarely do so we'd get warnings for most
> packages. As
> a side effect, people may pay less attention to what ‘guix lint’
> says.
Even I agree :-) There are valid reasons not to sort them.
> As for the goal itself, I think sorting is a good idea when
> there are
> lots of inputs (things like IceCat), but otherwise I personally
> don't
> think it matters that much.
Do we already check for duplication?
I sometimes order inputs for the same reason I sort module
imports: to catch duplicates. These are usually harmless and
produce no errors.
Kind regards,
T G-R
next prev parent reply other threads:[~2018-12-08 5:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 7:42 [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted Arun Isaac
2018-12-03 13:31 ` Ludovic Courtès
2018-12-04 9:13 ` Tobias Geerinckx-Rice [this message]
2018-12-08 13:29 ` Ludovic Courtès
2018-12-06 0:42 ` Oleg Pykhalov
2018-12-06 12:31 ` swedebugia
2018-12-07 13:08 ` Maxim Cournoyer
2018-12-08 3:51 ` 宋文武
2018-12-08 7:58 ` swedebugia
2018-12-08 13:34 ` Arun Isaac
2018-12-09 22:49 ` Maxim Cournoyer
2018-12-10 11:45 ` 宋文武
2018-12-10 11:19 ` 宋文武
2018-12-18 20:36 ` bug#33575: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woopk639.fsf@nckx \
--to=somebody@not-sent-or-endorsed-by.tobias.gr \
--cc=33575@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).