unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: swedebugia@riseup.net
Cc: 33575@debbugs.gnu.org,
	Guix-patches <guix-patches-bounces+swedebugia=riseup.net@gnu.org>
Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted.
Date: Fri, 07 Dec 2018 08:08:13 -0500	[thread overview]
Message-ID: <87zhthmqma.fsf@gmail.com> (raw)
In-Reply-To: <1f7a7e5589c465c0ad913b388374cf4b@riseup.net> (swedebugia's message of "Thu, 06 Dec 2018 04:31:28 -0800")

swedebugia@riseup.net writes:

> On 2018-12-06 01:42, Oleg Pykhalov wrote:
>> Hello,
>> 
>> ludo@gnu.org (Ludovic Courtès) writes:
>> 
>> […]
>> 
>>> It’s something we rarely do so we’d get warnings for most packages.  As
>>> a side effect, people may pay less attention to what ‘guix lint’ says.
>> 
>> I think this should not stop us from improving a linter and an option
>> like --misc-checks=sort-input,foo,bar could be used for such cases.
>
> I agree with Oleg here. 
>
> If many packages needs inputs to be sorted lets write a guix lint --sort
> modelling the updater (that is make the changes in the work tree to be
> committed).

+1

  reply	other threads:[~2018-12-07 13:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-02  7:42 [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted Arun Isaac
2018-12-03 13:31 ` Ludovic Courtès
2018-12-04  9:13   ` Tobias Geerinckx-Rice
2018-12-08 13:29     ` Ludovic Courtès
2018-12-06  0:42   ` Oleg Pykhalov
2018-12-06 12:31     ` swedebugia
2018-12-07 13:08       ` Maxim Cournoyer [this message]
2018-12-08  3:51 ` 宋文武
2018-12-08  7:58   ` swedebugia
2018-12-08 13:34   ` Arun Isaac
2018-12-09 22:49     ` Maxim Cournoyer
2018-12-10 11:45       ` 宋文武
2018-12-10 11:19     ` 宋文武
2018-12-18 20:36       ` bug#33575: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhthmqma.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=33575@debbugs.gnu.org \
    --cc=guix-patches-bounces+swedebugia=riseup.net@gnu.org \
    --cc=swedebugia@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).