From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVUsX-0002oF-4B
	for guix-patches@gnu.org; Sat, 08 Dec 2018 00:10:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVUsM-0003wc-ID
	for guix-patches@gnu.org; Sat, 08 Dec 2018 00:10:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33241)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gVUsM-0003wK-6O
	for guix-patches@gnu.org; Sat, 08 Dec 2018 00:10:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVUsL-0005Gy-Me
	for guix-patches@gnu.org; Sat, 08 Dec 2018 00:10:01 -0500
Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are
	sorted.
Resent-Message-ID: <handler.33575.B33575.154424576720220@debbugs.gnu.org>
From: Tobias Geerinckx-Rice <somebody@not-sent-or-endorsed-by.tobias.gr>
Date: Tue, 04 Dec 2018 10:13:14 +0100
Message-ID: <87woopk639.fsf@nckx>
References: <20181202074210.31361-1-arunisaac@systemreboot.net>
	<87y3967n3z.fsf@gnu.org>
In-reply-to: <87y3967n3z.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 33575@debbugs.gnu.org

Ludo', Arun,

Ludovic Court=C3=A8s wrote:
>> +  ;; Emit a warning if inputs, native inputs or propagated=20
>> inputs
>> of PACKAGE
>> +  ;; are not lexicographically ordered.
>
> It's something we rarely do so we'd get warnings for most
> packages.  As
> a side effect, people may pay less attention to what =E2=80=98guix lint=
=E2=80=99
> says.

Even I agree :-)  There are valid reasons not to sort them.

> As for the goal itself, I think sorting is a good idea when
> there are
> lots of inputs (things like IceCat), but otherwise I personally
> don't
> think it matters that much.

Do we already check for duplication?

I sometimes order inputs for the same reason I sort module=20
imports: to catch duplicates.  These are usually harmless and=20
produce no errors.

Kind regards,

T G-R