* [bug#35011] [PATCH] gnu: gpodder: Build reproducibly.
@ 2019-03-26 21:52 Pierre Langlois
2019-03-31 21:25 ` bug#35011: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Pierre Langlois @ 2019-03-26 21:52 UTC (permalink / raw)
To: 35011
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Hello Guix!
I just realised the gpodder package was not deterministic because of
'POT-Creation-Date' entries in the .po files. I forgot to check for
determinism before sending that patch, whoops! :-)
Tested with:
```
./pre-inst-env guix build --no-grafts --check --rounds=2 gpodder
(...)
/gnu/store/15l476abksby4awsnvckm3ai59fgxb9x-gpodder-3.10.7
```
Which would give us:
```
guix build: error: derivation `/gnu/store/k0my78v8n5r9xdxcip3q7dm6xzb80-gpodder-3.10.7.drv' may not be deterministic: output `/gnu/store/fmaplc6y2dv4ys3n4fcpziaw83p3smf4-gpodder-3.10.7' differs
```
Thanks!
Pierre
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gpodder-Build-reproducibly.patch --]
[-- Type: text/x-patch, Size: 1142 bytes --]
From 2e45e7c875b384e80099f9ce76009e2116472ef2 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Tue, 26 Mar 2019 21:41:59 +0000
Subject: [PATCH] gnu: gpodder: Build reproducibly.
* gnu/packages/gpodder.scm (gpodder)[arguments]: Add 'do-not-run-msgmerge'
phase before 'install'.
---
gnu/packages/gpodder.scm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
index ea1a3108ca..badb7f867f 100644
--- a/gnu/packages/gpodder.scm
+++ b/gnu/packages/gpodder.scm
@@ -69,6 +69,13 @@
(substitute* "src/gpodder/util.py"
(("xdg-open") (string-append xdg-utils "/bin/xdg-open")))
#t)))
+ ;; 'msgmerge' introduces non-determinism by resetting the
+ ;; POT-Creation-Date in .po files.
+ (add-before 'install 'do-not-run-msgmerge
+ (lambda _
+ (substitute* "makefile"
+ (("msgmerge") "true"))
+ #t))
(add-before 'install 'make-po-files-writable
(lambda _
(for-each
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#35011: [PATCH] gnu: gpodder: Build reproducibly.
2019-03-26 21:52 [bug#35011] [PATCH] gnu: gpodder: Build reproducibly Pierre Langlois
@ 2019-03-31 21:25 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2019-03-31 21:25 UTC (permalink / raw)
To: Pierre Langlois; +Cc: 35011-done
Hello,
Pierre Langlois <pierre.langlois@gmx.com> skribis:
> I just realised the gpodder package was not deterministic because of
> 'POT-Creation-Date' entries in the .po files. I forgot to check for
> determinism before sending that patch, whoops! :-)
Good catch!
> From 2e45e7c875b384e80099f9ce76009e2116472ef2 Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois@gmx.com>
> Date: Tue, 26 Mar 2019 21:41:59 +0000
> Subject: [PATCH] gnu: gpodder: Build reproducibly.
>
> * gnu/packages/gpodder.scm (gpodder)[arguments]: Add 'do-not-run-msgmerge'
> phase before 'install'.
Applied, thank you!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-31 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26 21:52 [bug#35011] [PATCH] gnu: gpodder: Build reproducibly Pierre Langlois
2019-03-31 21:25 ` bug#35011: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).