From: Pierre Langlois <pierre.langlois@gmx.com>
To: 35011@debbugs.gnu.org
Subject: [bug#35011] [PATCH] gnu: gpodder: Build reproducibly.
Date: Tue, 26 Mar 2019 21:52:33 +0000 [thread overview]
Message-ID: <87wokll2vy.fsf@gmx.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Hello Guix!
I just realised the gpodder package was not deterministic because of
'POT-Creation-Date' entries in the .po files. I forgot to check for
determinism before sending that patch, whoops! :-)
Tested with:
```
./pre-inst-env guix build --no-grafts --check --rounds=2 gpodder
(...)
/gnu/store/15l476abksby4awsnvckm3ai59fgxb9x-gpodder-3.10.7
```
Which would give us:
```
guix build: error: derivation `/gnu/store/k0my78v8n5r9xdxcip3q7dm6xzb80-gpodder-3.10.7.drv' may not be deterministic: output `/gnu/store/fmaplc6y2dv4ys3n4fcpziaw83p3smf4-gpodder-3.10.7' differs
```
Thanks!
Pierre
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gpodder-Build-reproducibly.patch --]
[-- Type: text/x-patch, Size: 1142 bytes --]
From 2e45e7c875b384e80099f9ce76009e2116472ef2 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Tue, 26 Mar 2019 21:41:59 +0000
Subject: [PATCH] gnu: gpodder: Build reproducibly.
* gnu/packages/gpodder.scm (gpodder)[arguments]: Add 'do-not-run-msgmerge'
phase before 'install'.
---
gnu/packages/gpodder.scm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
index ea1a3108ca..badb7f867f 100644
--- a/gnu/packages/gpodder.scm
+++ b/gnu/packages/gpodder.scm
@@ -69,6 +69,13 @@
(substitute* "src/gpodder/util.py"
(("xdg-open") (string-append xdg-utils "/bin/xdg-open")))
#t)))
+ ;; 'msgmerge' introduces non-determinism by resetting the
+ ;; POT-Creation-Date in .po files.
+ (add-before 'install 'do-not-run-msgmerge
+ (lambda _
+ (substitute* "makefile"
+ (("msgmerge") "true"))
+ #t))
(add-before 'install 'make-po-files-writable
(lambda _
(for-each
--
2.21.0
next reply other threads:[~2019-03-26 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 21:52 Pierre Langlois [this message]
2019-03-31 21:25 ` bug#35011: [PATCH] gnu: gpodder: Build reproducibly Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wokll2vy.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=35011@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).