From: Marius Bakke <marius@gnu.org>
To: Morgan.J.Smith@outlook.com, 41567@debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith@outlook.com>
Subject: [bug#41567] [PATCH] gnu: Add mspdebug.
Date: Sat, 30 May 2020 15:53:19 +0200 [thread overview]
Message-ID: <87wo4tzfzk.fsf@gnu.org> (raw)
In-Reply-To: <DM5PR1001MB2105C89D713D8507F978DC08C5B10@DM5PR1001MB2105.namprd10.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]
Morgan.J.Smith@outlook.com writes:
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/mspdebug.scm (mspdebug): New variable.
Can you move this package to gnu/packages/debug.scm instead of adding a
new module?
[...]
> +(define-public mspdebug
> + (package
> + (name "mspdebug")
> + (version "0.25")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/dlbeer/mspdebug.git")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0prgwb5vx6fd4bj12ss1bbb6axj2kjyriyjxqrzd58s5jyyy8d3c"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases (delete 'configure) (delete 'check))
> + #:make-flags
> + (let ((target ,(%current-target-system)))
> + (list (string-append "CC=" (if target
> + (string-append target "-gcc")
> + "gcc"))
Since very recently, you can now use:
(string-append "CC=" ,(cc-for-target))
instead of the let binding and conditional.
> + "INSTALL=install"
> + (string-append "PREFIX=" %output)))))
> + (inputs
> + `(("libusb-compat" ,libusb-compat)
> + ("readline" ,readline)))
> + (synopsis "Free debugger for use with MSP430 MCUs")
No need to mention free here, since everything in Guix is free
software. The GitHub tagline is pretty good:
Debugging tool for MSP430 MCUs
> + (description "MspDebug supports FET430UIF, eZ430, RF2500 and Olimex
> +MSP430-JTAG-TINY programmers, as well as many other compatible
> +devices. It can be used as a proxy for gdb or as an independent
> +debugger with support for programming, disassembly and reverse
> +engineering.")
> + (home-page "https://github.com/dlbeer/mspdebug")
> + (license gpl2)))
This should be 'gpl2+', since the source files say "GPL 2 or any later
version".
Can you send an updated patch? Thanks in advance!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-05-30 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 17:34 [bug#41567] [PATCH] gnu: Add mspdebug Morgan.J.Smith
2020-05-30 13:53 ` Marius Bakke [this message]
2020-05-30 19:03 ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-30 20:33 ` Morgan.J.Smith
2020-05-30 21:18 ` bug#41567: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo4tzfzk.fsf@gnu.org \
--to=marius@gnu.org \
--cc=41567@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).