From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +CDcKIFl0l4QVwAA0tVLHw (envelope-from ) for ; Sat, 30 May 2020 13:54:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qF/JJIFl0l5QVQAAB5/wlQ (envelope-from ) for ; Sat, 30 May 2020 13:54:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 254E6940308 for ; Sat, 30 May 2020 13:54:09 +0000 (UTC) Received: from localhost ([::1]:58568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf1w7-0000zp-Dn for larch@yhetil.org; Sat, 30 May 2020 09:54:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf1w1-0000zi-Sm for guix-patches@gnu.org; Sat, 30 May 2020 09:54:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jf1w1-0002as-K3 for guix-patches@gnu.org; Sat, 30 May 2020 09:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jf1w1-0001wv-ID for guix-patches@gnu.org; Sat, 30 May 2020 09:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41567] [PATCH] gnu: Add mspdebug. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 May 2020 13:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41567 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan.J.Smith@outlook.com, 41567@debbugs.gnu.org Cc: Morgan Smith Received: via spool by 41567-submit@debbugs.gnu.org id=B41567.15908468097450 (code B ref 41567); Sat, 30 May 2020 13:54:01 +0000 Received: (at 41567) by debbugs.gnu.org; 30 May 2020 13:53:29 +0000 Received: from localhost ([127.0.0.1]:57199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf1vV-0001w6-7g for submit@debbugs.gnu.org; Sat, 30 May 2020 09:53:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf1vU-0001vv-4n for 41567@debbugs.gnu.org; Sat, 30 May 2020 09:53:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35064) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf1vO-00027y-FO; Sat, 30 May 2020 09:53:22 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:53896 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jf1vN-0000L3-TI; Sat, 30 May 2020 09:53:22 -0400 From: Marius Bakke In-Reply-To: References: Date: Sat, 30 May 2020 15:53:19 +0200 Message-ID: <87wo4tzfzk.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: E9e3guHOvYmo --=-=-= Content-Type: text/plain Morgan.J.Smith@outlook.com writes: > From: Morgan Smith > > * gnu/packages/mspdebug.scm (mspdebug): New variable. Can you move this package to gnu/packages/debug.scm instead of adding a new module? [...] > +(define-public mspdebug > + (package > + (name "mspdebug") > + (version "0.25") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/dlbeer/mspdebug.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0prgwb5vx6fd4bj12ss1bbb6axj2kjyriyjxqrzd58s5jyyy8d3c")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases (modify-phases %standard-phases (delete 'configure) (delete 'check)) > + #:make-flags > + (let ((target ,(%current-target-system))) > + (list (string-append "CC=" (if target > + (string-append target "-gcc") > + "gcc")) Since very recently, you can now use: (string-append "CC=" ,(cc-for-target)) instead of the let binding and conditional. > + "INSTALL=install" > + (string-append "PREFIX=" %output))))) > + (inputs > + `(("libusb-compat" ,libusb-compat) > + ("readline" ,readline))) > + (synopsis "Free debugger for use with MSP430 MCUs") No need to mention free here, since everything in Guix is free software. The GitHub tagline is pretty good: Debugging tool for MSP430 MCUs > + (description "MspDebug supports FET430UIF, eZ430, RF2500 and Olimex > +MSP430-JTAG-TINY programmers, as well as many other compatible > +devices. It can be used as a proxy for gdb or as an independent > +debugger with support for programming, disassembly and reverse > +engineering.") > + (home-page "https://github.com/dlbeer/mspdebug") > + (license gpl2))) This should be 'gpl2+', since the source files say "GPL 2 or any later version". Can you send an updated patch? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SZU8ACgkQoqBt8qM6 VPoWhwf/eTDiIu5QQMDAGCZ0+JRIR3DCF8zuyj+w/RayLjz4HcH3ORfg7RoIcWgx EnR1q9ajjh17Qi3bx+j4P1d8TsGRJDcs5Ggx6HGG+ZTdTtvylI1YxNCcvX476cv8 7guMTbPGoAJcgqy7JMaqiPFGYaTDP6vnfixVeBdybW0XJ491ptgkGvJPSc1/X5zB GOQwwgATXrDNFJBXxsi7ewekAB32jRGcEOCN9xsRd5/VyQ00hDM6+UWMcfG8yetD U3MVpLVApJSDLx0Hnka7sHdu6DC8JbPvXWoiVBL324ZN3TpP3UG8uUc3v3P9gkjT jOqhBKLPCuZjkOANNXbtxCdA9a8ciA== =bavB -----END PGP SIGNATURE----- --=-=-=--