unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Morgan.J.Smith@outlook.com
Cc: 41567@debbugs.gnu.org
Subject: [bug#41567] [PATCH] gnu: Add mspdebug.
Date: Sat, 30 May 2020 21:03:21 +0200	[thread overview]
Message-ID: <874krx1c06.fsf@nckx> (raw)
In-Reply-To: <DM5PR1001MB2105C89D713D8507F978DC08C5B10@DM5PR1001MB2105.namprd10.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Morgan,

Morgan.J.Smith@outlook.com 写道：
> +     `(#:phases (modify-phases %standard-phases (delete 
> 'configure) (delete 'check))

Try to keep lines within 80 characters.  Have you heard of our 
lord & saviour ‘guix lint’?  It's nitpicking like this, automated.

There's a more ‘declarative’ way to disable tests.  Add a short 
note why:

  `(#:tests? #f                         ; no test suite
    #:phases
    (modify-phases %standard-phases
      (delete 'configure)))             ; no configure script

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  parent reply	other threads:[~2020-05-30 19:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 17:34 [bug#41567] [PATCH] gnu: Add mspdebug Morgan.J.Smith
2020-05-30 13:53 ` Marius Bakke
2020-05-30 19:03 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-05-30 20:33 ` Morgan.J.Smith
2020-05-30 21:18   ` bug#41567: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874krx1c06.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=41567@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).