From: Katherine Cox-Buday <cox.katherine.e@gmail.com>
To: Attila Lendvai <attila@lendvai.name>
Cc: 54906@debbugs.gnu.org
Subject: [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t.
Date: Wed, 27 Apr 2022 12:42:02 -0500 [thread overview]
Message-ID: <87wnfamnit.fsf@gmail.com> (raw)
In-Reply-To: <20220413120052.25602-1-attila@lendvai.name> (Attila Lendvai's message of "Wed, 13 Apr 2022 14:00:42 +0200")
(Please forgive me for using your patch to try out reviewing some Guix
patches! This is also my first time reviewing code over email, so feedback welcome!)
I don't have the context for why such a change is needed, but purely from a code perspective this LGTM.
Unfortunately I have no power to commit this.
--
Katherine
next prev parent reply other threads:[~2022-04-27 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:00 [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t Attila Lendvai
2022-04-14 10:38 ` Ricardo Wurmus
2022-04-27 16:33 ` [bug#54906] ping Attila Lendvai
2022-04-27 17:42 ` Katherine Cox-Buday [this message]
2022-04-27 19:22 ` [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t Maxime Devos
2022-04-28 10:56 ` Attila Lendvai
2022-04-28 11:35 ` Maxime Devos
2022-04-28 12:14 ` Attila Lendvai
2022-06-13 1:53 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnfamnit.fsf@gmail.com \
--to=cox.katherine.e@gmail.com \
--cc=54906@debbugs.gnu.org \
--cc=attila@lendvai.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).