From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yLtbL/qAaWLXJgEAbAwnHQ (envelope-from ) for ; Wed, 27 Apr 2022 19:44:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4DGbL/qAaWKRgwEAauVa8A (envelope-from ) for ; Wed, 27 Apr 2022 19:44:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 733BAC338 for ; Wed, 27 Apr 2022 19:44:26 +0200 (CEST) Received: from localhost ([::1]:52906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njliD-0004yE-84 for larch@yhetil.org; Wed, 27 Apr 2022 13:44:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njlgy-0004xq-M4 for guix-patches@gnu.org; Wed, 27 Apr 2022 13:43:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50383) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njlgs-0004Hq-FQ for guix-patches@gnu.org; Wed, 27 Apr 2022 13:43:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njlgs-000179-BI for guix-patches@gnu.org; Wed, 27 Apr 2022 13:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t. Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Apr 2022 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54906 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 54906@debbugs.gnu.org Received: via spool by 54906-submit@debbugs.gnu.org id=B54906.16510813304209 (code B ref 54906); Wed, 27 Apr 2022 17:43:02 +0000 Received: (at 54906) by debbugs.gnu.org; 27 Apr 2022 17:42:10 +0000 Received: from localhost ([127.0.0.1]:44280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njlg2-00015p-KL for submit@debbugs.gnu.org; Wed, 27 Apr 2022 13:42:10 -0400 Received: from mail-qv1-f50.google.com ([209.85.219.50]:36426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njlg1-00015c-Ns for 54906@debbugs.gnu.org; Wed, 27 Apr 2022 13:42:09 -0400 Received: by mail-qv1-f50.google.com with SMTP id q13so1569137qvk.3 for <54906@debbugs.gnu.org>; Wed, 27 Apr 2022 10:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=29WJjFMuNYdyhr4nKGhQ3mL/z/4JKWd1ZNRIrfHhFdY=; b=b84h+HBt+rl/gu6M0wX8hnCZqK7XgMbC1E/atpLB8vjC3yph+HyFUdb4e1LC4IN2QD t+DdX+0zFTNAQlyiy4/qBLTg2uWAepaGXBUYw9+teoiZ6YfTKN+col3TvC+6VZz5+OnQ SxI4jlxzJv2GvcYo5cKT8sNsPR6/iVMkIHFiEJ8koNfQNjCVCQKyTZ4czcauaLgoBz03 HLRVpLszd8dz258spBfme1ydvfOAKPApP79pVrOi1369Ibtn3Tppb4me53Z5JMdPfYI5 02OasiGpfBnlRB+4+yFSfTIaFo/Fbg+Kt6yTL41b5XVZ19ewQbwAJUT8utRk+ZwOQ4tj Qwuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=29WJjFMuNYdyhr4nKGhQ3mL/z/4JKWd1ZNRIrfHhFdY=; b=W/vJLJuKmpfp5nu9qgkP6OL1uYI7BkzHcTELwjQuOfIjRTzCuYw9nENaVUqhvsQqqD iygTx4PA+7wdnivCuLvlc54FbHoNuCYL1UgWKconAeB4ngJKA0uRHCjgmP2LgSD2b2by myDJdaDY8u4UaJ5PXVhOSiFHuCs9iWOSSxnIifUl3Wu/dtqSPAf1yuu7a74apFmMrCS6 FmobNGTI9Hk7wPe2Zyt21QsXTIy0iJxalSr5y3wY8GHoOUiN4Xj9pRZGCLRdQCsC/Zft FPenVYHTemODez0Xw2R6zYOCjqbauWUmB9WtfdGp8JlsEb6qf/QCWhWt8Om8sNkpFIFe cfxQ== X-Gm-Message-State: AOAM530vFF8AZNQcd35fJsLfTt3t/X1sZA6pPZOoIOf+YoGg5YT6p5sY NnxqtOdxDJOpAqKYPKRR9HLNR9qhYxjljg== X-Google-Smtp-Source: ABdhPJxvlTNd71h1AABym/mnT8C1tODj23hN+3316biJnfzhusk9F73xjCRpQOIscSin3WNw8DTYkw== X-Received: by 2002:a05:6214:e4a:b0:449:99fd:bff7 with SMTP id o10-20020a0562140e4a00b0044999fdbff7mr20812396qvc.46.1651081324030; Wed, 27 Apr 2022 10:42:04 -0700 (PDT) Received: from washu-v4 (172-221-246-205.res.spectrum.com. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id c14-20020a05620a268e00b0069f99676880sm590974qkp.80.2022.04.27.10.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 10:42:03 -0700 (PDT) From: Katherine Cox-Buday References: <20220413120052.25602-1-attila@lendvai.name> Date: Wed, 27 Apr 2022 12:42:02 -0500 In-Reply-To: <20220413120052.25602-1-attila@lendvai.name> (Attila Lendvai's message of "Wed, 13 Apr 2022 14:00:42 +0200") Message-ID: <87wnfamnit.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651081466; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=29WJjFMuNYdyhr4nKGhQ3mL/z/4JKWd1ZNRIrfHhFdY=; b=YzrC/oCAG9rgghdmo2Mas5Piur4Qw5cVmiY4nO7zogpJ/rjBNRJ/4Qepr9hG7YL71Nmde/ UxX5Di7JuOGT1B1J9H2pkAx8yfiCCu5jOnH8sLpRiNQdiP0Vgh6vw6MXYeQse2v5+BOIA5 4FI/GVcWtVIEwGEbm+y5fUIE3KIgbaF8HyxlyALR4V9hPZnTzWYsvb+V+do8D4AGyK+4bZ yWkVrmRaW3yrtZ8dY9Jl3xSjTL5mO8KNomRAFteMR5YzDlwWqXoEQy6ymDRxKa5orLCwSA LZFpvV9Ws/CB/t7n1+tVfsyMOOY7siIdagJCuJZ8AcIYhEAxakk/+APorkh4dw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651081466; a=rsa-sha256; cv=none; b=YQ9RFK7KL0Omdkdu6ndcD0XhZfsGidGaFEjcKRvpfZjJe+alOveeTPtCKWxs2BTkH4QSMo cOF1VEg342Mp/INEDGZBptpLO7yNuCw3UTryYojRmoAA9C2du6TJfiIaCmVgeEbtX/GYxH UVjq6J3ALVVElTFUcp3EZW2y6lOsWXfVLNFihN2PBQrwui7FrHgTQnDu4oaZbfndxkb+52 UOHDJp+16YwXWmQGv4bLkgxKWHe2TTaoQ2UIcaYEcR2Gi8/+PAPfOxm7579MbHTwGCUAMY +Ivgw3G6DnABNcX3lw+YQbO71i+4HVk9xVa/LM/Qop+vvkeqtDLBtMWqwRzrnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=b84h+HBt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=b84h+HBt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 733BAC338 X-Spam-Score: 6.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: bIErodPs5sqF (Please forgive me for using your patch to try out reviewing some Guix patches! This is also my first time reviewing code over email, so feedback welcome!) I don't have the context for why such a change is needed, but purely from a code perspective this LGTM. Unfortunately I have no power to commit this. -- Katherine