unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Attila Lendvai <attila@lendvai.name>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54906@debbugs.gnu.org
Subject: [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t.
Date: Thu, 28 Apr 2022 10:56:20 +0000	[thread overview]
Message-ID: <gbg-UILYI0h6xq8as2NN44n3kwhNDtu1kzG-UhEYKIYSQgUgy8ZcIqGIDLbd4-qGbota7T5SO8AH_uLIcLyX5VQ6h6URaTRhfTcuycVTpeo=@lendvai.name> (raw)
In-Reply-To: <e375a336cf2622663357ea3e8c37e236133eb846.camel@telenet.be>

> The new WIP antioxidant-build-system (intended to replace cargo-build-
> system) will not have #:skip-build?, because the new build system
> actually reuses the build results off the dependents.
>
> Likewise, maybe long-term someone will figure out how to do something
> similar for go -- e.g.,
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32919#5 mentions a ‘go
> build cache’.
>
> So it seems more of a work-around than a feature to me.


i lack here the necessary resolution from the bird's eye view
perspective, so let me describe the actual ache that i'm trying to
resolve with this:

currently, the GO-BUILD-SYSTEM does not reuse build artifacts of the
dependencies, only includes them as source.

in the current setup, i.e. without SKIP-BUILD?, if i want to import an
app with 100+ dependencies, then i need to make sure that all those
100+ dependencies build fine by themselves. this is substantially more
work.

if there is SKIP-BUILD?, then i can just set it to false in the
importer for all the dependencies, and only flip it to true for the
leaf packages that i'm actualy trying to build.

it seems to me that i should just remove the SKIP-BUILD? assumption
from the go importer for now, and file my commits against vanilla
master.

i'll proceed with that.

thanks for the feedback!

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“People do not seem to realize that their opinion of the world is also a confession of character.”
	— Ralph Waldo Emerson (1803–1882)





  reply	other threads:[~2022-04-28 11:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 12:00 [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t Attila Lendvai
2022-04-14 10:38 ` Ricardo Wurmus
2022-04-27 16:33 ` [bug#54906] ping Attila Lendvai
2022-04-27 17:42 ` [bug#54906] [PATCH] build: go-build-system: Add support for #:skip-build? #t Katherine Cox-Buday
2022-04-27 19:22 ` Maxime Devos
2022-04-28 10:56   ` Attila Lendvai [this message]
2022-04-28 11:35     ` Maxime Devos
2022-04-28 12:14       ` Attila Lendvai
2022-06-13  1:53         ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gbg-UILYI0h6xq8as2NN44n3kwhNDtu1kzG-UhEYKIYSQgUgy8ZcIqGIDLbd4-qGbota7T5SO8AH_uLIcLyX5VQ6h6URaTRhfTcuycVTpeo=@lendvai.name' \
    --to=attila@lendvai.name \
    --cc=54906@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).