* [bug#30439] [PATCH] gnu: Add qqc2-desktop-style.
@ 2018-02-12 22:55 Hartmut Goebel
[not found] ` <handler.30439.B.151847613019602.ack@debbugs.gnu.org>
2018-02-13 22:11 ` Marius Bakke
0 siblings, 2 replies; 4+ messages in thread
From: Hartmut Goebel @ 2018-02-12 22:55 UTC (permalink / raw)
To: 30439
* gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
variable.
---
gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d5e3c796e..1b43b66ae 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1275,6 +1275,38 @@ which are used in DBus communication.")
provides uniform access to generation of barcodes with data.")
(license license:lgpl2.1+)))
+(define-public qqc2-desktop-style
+ (package
+ (name "qqc2-desktop-style")
+ (version "5.42.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "mirror://kde/stable/frameworks/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
+ (build-system cmake-build-system)
+ (native-inputs
+ `(("extra-cmake-modules" ,extra-cmake-modules)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("kauth" ,kauth)
+ ("kconfigwidgets" ,kconfigwidgets) ;; optional
+ ("kcoreaddons" ,kcoreaddons)
+ ("kiconthemes" ,kiconthemes) ;; optional
+ ("kirigami" ,kirigami)
+ ("qtbase" ,qtbase)
+ ("qtdeclarative" ,qtdeclarative)))
+ (home-page "https://community.kde.org/Frameworks")
+ (synopsis "QtQuickControls2 style that integrates with the desktop")
+ (description "This is a style for QtQuicControls2 which is using QWidget's
+QStyle to paint the controls in order to give it a native look and feel.
+")
+ (license (list license:gpl3+ license:lgpl2.1+))))
+
(define-public solid
(package
(name "solid")
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <handler.30439.B.151847613019602.ack@debbugs.gnu.org>]
* [bug#30439] [PATCH] gnu: Add qqc2-desktop-style.
2018-02-12 22:55 [bug#30439] [PATCH] gnu: Add qqc2-desktop-style Hartmut Goebel
[not found] ` <handler.30439.B.151847613019602.ack@debbugs.gnu.org>
@ 2018-02-13 22:11 ` Marius Bakke
2018-02-15 21:15 ` bug#30439: " Hartmut Goebel
1 sibling, 1 reply; 4+ messages in thread
From: Marius Bakke @ 2018-02-13 22:11 UTC (permalink / raw)
To: Hartmut Goebel, 30439
[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> * gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
> variable.
[...]
> +(define-public qqc2-desktop-style
> + (package
> + (name "qqc2-desktop-style")
> + (version "5.42.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://kde/stable/frameworks/"
> + (version-major+minor version) "/"
> + name "-" version ".tar.xz"))
> + (sha256
> + (base32
> + "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
> + (build-system cmake-build-system)
> + (native-inputs
> + `(("extra-cmake-modules" ,extra-cmake-modules)
> + ("pkg-config" ,pkg-config)))
> + (inputs
> + `(("kauth" ,kauth)
> + ("kconfigwidgets" ,kconfigwidgets) ;; optional
> + ("kcoreaddons" ,kcoreaddons)
> + ("kiconthemes" ,kiconthemes) ;; optional
Nit-pick: only a single semicolon for inline comments.
> + ("kirigami" ,kirigami)
> + ("qtbase" ,qtbase)
> + ("qtdeclarative" ,qtdeclarative)))
> + (home-page "https://community.kde.org/Frameworks")
> + (synopsis "QtQuickControls2 style that integrates with the desktop")
> + (description "This is a style for QtQuicControls2 which is using QWidget's
^^^ missing 'k'
> +QStyle to paint the controls in order to give it a native look and feel.
> +")
This can be moved to the end of the previous line.
> + (license (list license:gpl3+ license:lgpl2.1+))))
I'm not familiar with KDE, is everything dual licensed as
GPL3+/LGPL2.1+? If not, please add a comment explaining what is covered
by which license (or clarify whether it's dual-licensed).
Otherwise LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#30439: [PATCH] gnu: Add qqc2-desktop-style.
2018-02-13 22:11 ` Marius Bakke
@ 2018-02-15 21:15 ` Hartmut Goebel
0 siblings, 0 replies; 4+ messages in thread
From: Hartmut Goebel @ 2018-02-15 21:15 UTC (permalink / raw)
To: Marius Bakke, 30439-close
Thanks for the review. I addressed your remarks and will push it later
together with [#30398] (Update KDE Frameworks to 5.42.0 and other KDE
stuff respectively)
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-15 21:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-12 22:55 [bug#30439] [PATCH] gnu: Add qqc2-desktop-style Hartmut Goebel
[not found] ` <handler.30439.B.151847613019602.ack@debbugs.gnu.org>
2018-02-12 22:59 ` Hartmut Goebel
2018-02-13 22:11 ` Marius Bakke
2018-02-15 21:15 ` bug#30439: " Hartmut Goebel
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).