From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elio3-0007Y0-90 for guix-patches@gnu.org; Tue, 13 Feb 2018 17:12:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eliny-0005tn-7U for guix-patches@gnu.org; Tue, 13 Feb 2018 17:12:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:34001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elinx-0005tW-TL for guix-patches@gnu.org; Tue, 13 Feb 2018 17:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elinx-0003RX-I7 for guix-patches@gnu.org; Tue, 13 Feb 2018 17:12:01 -0500 Subject: [bug#30439] [PATCH] gnu: Add qqc2-desktop-style. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180212225511.9403-1-h.goebel@crazy-compilers.com> References: <20180212225511.9403-1-h.goebel@crazy-compilers.com> Date: Tue, 13 Feb 2018 23:11:05 +0100 Message-ID: <87vaf0wneu.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hartmut Goebel , 30439@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hartmut Goebel writes: > * gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New > variable. [...] =20=20 > +(define-public qqc2-desktop-style > + (package > + (name "qqc2-desktop-style") > + (version "5.42.0") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://kde/stable/frameworks/" > + (version-major+minor version) "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))= )) > + (build-system cmake-build-system) > + (native-inputs > + `(("extra-cmake-modules" ,extra-cmake-modules) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("kauth" ,kauth) > + ("kconfigwidgets" ,kconfigwidgets) ;; optional > + ("kcoreaddons" ,kcoreaddons) > + ("kiconthemes" ,kiconthemes) ;; optional Nit-pick: only a single semicolon for inline comments. > + ("kirigami" ,kirigami) > + ("qtbase" ,qtbase) > + ("qtdeclarative" ,qtdeclarative))) > + (home-page "https://community.kde.org/Frameworks") > + (synopsis "QtQuickControls2 style that integrates with the desktop") > + (description "This is a style for QtQuicControls2 which is using QWi= dget's ^^^ missing 'k' > +QStyle to paint the controls in order to give it a native look and feel. > +") This can be moved to the end of the previous line. > + (license (list license:gpl3+ license:lgpl2.1+)))) I'm not familiar with KDE, is everything dual licensed as GPL3+/LGPL2.1+? If not, please add a comment explaining what is covered by which license (or clarify whether it's dual-licensed). Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqDYnkACgkQoqBt8qM6 VPqU3QgAk9iYpqEKdx6ufGvyiNV1d5ErHA+8EzTVXcyL7iMBy5/O8BKyJlJRWEyI 4jAJpwzfq2F+5rt/ZUQR5VDbh37Isf8gR/z89uCATwwgpuwnR6d9Xg0+jmlaK4i8 9XlhJ8eGVtj5rr8PGGxoCxy4vFfb6qtmoUuNPnXvwowGxRGR5QMeH/U5M0lQ000q 5iCN4saJAQaEVfBZDOy/oDdJnWW7HhdNT+TY4Ho1I1lC0u1rmrZx8rla5diC1b0M rDGtF/FaupKjPVZ7BGNc5x2UKvdXnZp3Us9LcFpn8yoNEmJyn6zPEPl7dYhYfI5l GytwQr8Y4MsHP8X7Mb6nVjJMYlRyEg== =16Qe -----END PGP SIGNATURE----- --=-=-=--