From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund@posteo.net>
Cc: 43722@debbugs.gnu.org
Subject: [bug#43722] Add emacs-gcmh package
Date: Thu, 01 Oct 2020 14:32:58 +0200 [thread overview]
Message-ID: <87v9fu15z9.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87sgazgzao.fsf@posteo.net> (Niklas Eklund's message of "Wed, 30 Sep 2020 15:38:23 +0200")
Hello,
Niklas Eklund <niklas.eklund@posteo.net> writes:
> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
Thank you.
Some comments follow.
> +(define-public emacs-gcmh
> + (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
> + (revision "0"))
Could you add a comment explaining why we're providing a specific commit
instead of a tagged release?
> + (package
> + (name "emacs-gcmh")
> + (version (git-version "0.1" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.com/koral/gcmh")
> + (commit commit)))
> + (sha256
> + (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
> + (file-name (git-file-name name version))))
> + (build-system emacs-build-system)
> + (home-page "https://gitlab.com/koral/gcmh")
> + (synopsis
> + "The GNU Emacs Garbage Collector Magic Hack")
The string should be moved on the same line as `synopsis'. Also:
Emacs Garbage Collector Magic Hack
is enough.
> + (description
> + "This package enforces a sneaky Garbage Collection strategy to minimize
I suggest
... a sneaky @dfn{garbage collector} (GC) strategy to minimize...
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-01 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 13:38 [bug#43722] Add emacs-gcmh package Niklas Eklund
2020-09-30 15:59 ` [bug#43722] [PATCH] gnu: Add emacs-gcmh Niklas Eklund
2020-10-01 12:32 ` Nicolas Goaziou [this message]
2020-10-01 19:32 ` [bug#43722] Add emacs-gcmh package Niklas Eklund
2020-10-14 9:24 ` bug#43722: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9fu15z9.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43722@debbugs.gnu.org \
--cc=niklas.eklund@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).