unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Niklas Eklund <niklas.eklund@posteo.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 43722@debbugs.gnu.org
Subject: [bug#43722] Add emacs-gcmh package
Date: Thu, 01 Oct 2020 21:32:02 +0200	[thread overview]
Message-ID: <87k0w9d9ot.fsf@posteo.net> (raw)
In-Reply-To: <87v9fu15z9.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1829 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Niklas Eklund <niklas.eklund@posteo.net> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
>
> Thank you.
>
> Some comments follow.
>
>> +(define-public emacs-gcmh
>> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
>> +        (revision "0"))
>
> Could you add a comment explaining why we're providing a specific commit
> instead of a tagged release?

I couldn't find a taged release on gitlab so I picked the most recent
commit. Upon looking closer there is not official tag to be found but in
the package it says version 0.1. What is the proper way of naming the
git version in this case? I changed it in this new patch to 0.0.0. Feel
free to change if it doesn't make sense.

>> +    (package
>> +      (name "emacs-gcmh")
>> +      (version (git-version "0.1" revision commit))
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://gitlab.com/koral/gcmh")
>> +               (commit commit)))
>> +         (sha256
>> +          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
>> +         (file-name (git-file-name name version))))
>> +      (build-system emacs-build-system)
>> +      (home-page "https://gitlab.com/koral/gcmh")
>> +      (synopsis
>> +       "The GNU Emacs Garbage Collector Magic Hack")
>
> The string should be moved on the same line as `synopsis'. Also:
>
>   Emacs Garbage Collector Magic Hack
>
> is enough.
>
>> +      (description
>> +       "This package enforces a sneaky Garbage Collection strategy to minimize
>
> I suggest 
>
>   ... a sneaky @dfn{garbage collector} (GC) strategy to minimize...
>
> Could you send an updated patch?

Good suggestions, I have addressed them and here is a new patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Content --]
[-- Type: text/x-patch, Size: 1753 bytes --]

From 0feb4bd289c7bab7b82e4d2f37fc7247acda6f6e Mon Sep 17 00:00:00 2001
From: Niklas Eklund <niklas.eklund@posteo.net>
Date: Wed, 30 Sep 2020 15:34:36 +0200
Subject: [PATCH v2] gnu: Add emacs-gcmh.

* gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13471f77d1..575ee25308 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1768,6 +1768,31 @@ always indented.  It reindents after every change, making it more reliable
 than @code{electric-indent-mode}.")
     (license license:gpl2+)))
 
+(define-public emacs-gcmh
+  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
+        (revision "0"))
+    (package
+      (name "emacs-gcmh")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://gitlab.com/koral/gcmh")
+               (commit commit)))
+         (sha256
+          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
+         (file-name (git-file-name name version))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/koral/gcmh")
+      (synopsis "Emacs Garbage Collector Magic Hack")
+      (description
+       "This package enforces a sneaky @dfn{garbage collector} (GC) strategy
+to minimize GC interference with the activity.  During normal use a high GC
+threshold is set.  When idling GC is immediately triggered and a low threshold
+is set.")
+      (license license:gpl3+))))
+
 (define-public emacs-ctrlf
   (package
     (name "emacs-ctrlf")
-- 
2.28.0


  reply	other threads:[~2020-10-01 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 13:38 [bug#43722] Add emacs-gcmh package Niklas Eklund
2020-09-30 15:59 ` [bug#43722] [PATCH] gnu: Add emacs-gcmh Niklas Eklund
2020-10-01 12:32 ` [bug#43722] Add emacs-gcmh package Nicolas Goaziou
2020-10-01 19:32   ` Niklas Eklund [this message]
2020-10-14  9:24     ` bug#43722: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0w9d9ot.fsf@posteo.net \
    --to=niklas.eklund@posteo.net \
    --cc=43722@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).