From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iL3WJNbMdV/PVwAA0tVLHw (envelope-from ) for ; Thu, 01 Oct 2020 12:34:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sN2wINbMdV9LYQAAB5/wlQ (envelope-from ) for ; Thu, 01 Oct 2020 12:34:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32E0B9402A6 for ; Thu, 1 Oct 2020 12:34:30 +0000 (UTC) Received: from localhost ([::1]:54386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNxn3-0000lJ-46 for larch@yhetil.org; Thu, 01 Oct 2020 08:34:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNxmc-0000kj-A0 for guix-patches@gnu.org; Thu, 01 Oct 2020 08:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51220) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNxmb-0000p7-Tc for guix-patches@gnu.org; Thu, 01 Oct 2020 08:34:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNxmb-0003vF-PX for guix-patches@gnu.org; Thu, 01 Oct 2020 08:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43722] Add emacs-gcmh package Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Oct 2020 12:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43722 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Niklas Eklund Cc: 43722@debbugs.gnu.org Received: via spool by 43722-submit@debbugs.gnu.org id=B43722.160155560014987 (code B ref 43722); Thu, 01 Oct 2020 12:34:01 +0000 Received: (at 43722) by debbugs.gnu.org; 1 Oct 2020 12:33:20 +0000 Received: from localhost ([127.0.0.1]:34515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNxlw-0003tf-JA for submit@debbugs.gnu.org; Thu, 01 Oct 2020 08:33:20 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNxlv-0003tR-2h for 43722@debbugs.gnu.org; Thu, 01 Oct 2020 08:33:20 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1ADC420008; Thu, 1 Oct 2020 12:33:09 +0000 (UTC) From: Nicolas Goaziou References: <87sgazgzao.fsf@posteo.net> Date: Thu, 01 Oct 2020 14:32:58 +0200 In-Reply-To: <87sgazgzao.fsf@posteo.net> (Niklas Eklund's message of "Wed, 30 Sep 2020 15:38:23 +0200") Message-ID: <87v9fu15z9.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 3GwMKr6YR0lT Hello, Niklas Eklund writes: > * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable. Thank you. Some comments follow. > +(define-public emacs-gcmh > + (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580") > + (revision "0")) Could you add a comment explaining why we're providing a specific commit instead of a tagged release? > + (package > + (name "emacs-gcmh") > + (version (git-version "0.1" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/koral/gcmh") > + (commit commit))) > + (sha256 > + (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3")) > + (file-name (git-file-name name version)))) > + (build-system emacs-build-system) > + (home-page "https://gitlab.com/koral/gcmh") > + (synopsis > + "The GNU Emacs Garbage Collector Magic Hack") The string should be moved on the same line as `synopsis'. Also: Emacs Garbage Collector Magic Hack is enough. > + (description > + "This package enforces a sneaky Garbage Collection strategy to minimize I suggest ... a sneaky @dfn{garbage collector} (GC) strategy to minimize... Could you send an updated patch? Regards, -- Nicolas Goaziou