From: "Ludovic Courtès" <ludo@gnu.org>
To: Brendan Tildesley <mail@brendan.scot>
Cc: 50428-done@debbugs.gnu.org
Subject: bug#50428: [PATCH] gnu: Add cryfs
Date: Thu, 16 Sep 2021 11:42:17 +0200 [thread overview]
Message-ID: <87v93026x2.fsf@gnu.org> (raw)
In-Reply-To: <20210906133437.3691-1-mail@brendan.scot> (Brendan Tildesley's message of "Mon, 6 Sep 2021 23:34:37 +1000")
Hi,
Brendan Tildesley <mail@brendan.scot> skribis:
> * gnu/packages/crypto.scm (cryfs): New variable.
Overall LGTM modulo the minor issues below:
> + '(#:configure-flags
> + `("-DCRYFS_UPDATE_CHECKS=OFF" ;; Note: This also disables checking for security issues.
> + "-DCMAKE_BUILD_TYPE=Release" ;; Build man pages.
Normally this is set by #:build-type. It defaults to “RelWithDebInfo”,
which is nice because then you get debugging symbols if you pass
‘--with-debug-info=cryfs’. So I’d suggest removing this second flag.
> + (replace 'check
> + (lambda* (#:key tests? outputs #:allow-other-keys)
> + (use-modules (srfi srfi-1))
Please use #:modules ((srfi srfi-1) …) instead of this non-top-level
‘use-modules’ form.
> + (when tests?
> + (with-directory-excursion "/tmp/build/test"
> + (let ((tests (find-files "." "-test$"))
> + (tests-output (assoc-ref outputs "tests")))
> + ;; Install tests to a separate output so users can run them.
> + (copy-recursively "." tests-output)
Installing tests is unusual. Do you really think it’s going to be
useful?
> + ;; XXX: Disable failing tests. Unfortunately there are a
> + ;; few. Some only fail in the build environment. ;; build
> + ;; environment.
Typo.
> + (description "CryFS encrypts your files, so you can safely store them anywhere.
> + It works well together with cloud services like Dropbox, iCloud, OneDrive and
^
Extra space. :-)
Could you send an updated patch?
Thanks!
Ludo’.
prev parent reply other threads:[~2021-09-16 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 13:34 [bug#50428] [PATCH] gnu: Add cryfs Brendan Tildesley
2021-09-14 9:50 ` bug#50428: " Ludovic Courtès
2021-09-14 12:13 ` [bug#50428] " Brendan Tildesley
2021-09-16 19:56 ` Ludovic Courtès
2021-09-16 9:42 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v93026x2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=50428-done@debbugs.gnu.org \
--cc=mail@brendan.scot \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).