bug#50428: [PATCH] gnu: Add cryfs

["Ludovic Courtès" <ludo@gnu.org>]

Hi,

Brendan Tildesley <mail@brendan.scot> skribis:

> * gnu/packages/crypto.scm (cryfs): New variable.

Overall LGTM modulo the minor issues below:

> +     '(#:configure-flags
> +       `("-DCRYFS_UPDATE_CHECKS=OFF" ;; Note: This also disables checking for security issues.
> +         "-DCMAKE_BUILD_TYPE=Release" ;; Build man pages.

Normally this is set by #:build-type.  It defaults to “RelWithDebInfo”,
which is nice because then you get debugging symbols if you pass
‘--with-debug-info=cryfs’.  So I’d suggest removing this second flag.

> +         (replace 'check
> +           (lambda* (#:key tests? outputs #:allow-other-keys)
> +             (use-modules (srfi srfi-1))

Please use #:modules ((srfi srfi-1) …) instead of this non-top-level
‘use-modules’ form.

> +             (when tests?
> +               (with-directory-excursion "/tmp/build/test"
> +                 (let ((tests (find-files "." "-test$"))
> +                       (tests-output (assoc-ref outputs "tests")))
> +                   ;; Install tests to a separate output so users can run them.
> +                   (copy-recursively "." tests-output)

Installing tests is unusual.  Do you really think it’s going to be
useful?

> +                   ;; XXX: Disable failing tests. Unfortunately there are a
> +                   ;; few. Some only fail in the build environment. ;; build
> +                   ;; environment.

Typo.

> +    (description "CryFS encrypts your files, so you can safely store them anywhere.
> + It works well together with cloud services like Dropbox, iCloud, OneDrive and
   ^
Extra space.  :-)

Could you send an updated patch?

Thanks!

Ludo’.