From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aO5OCrMRQ2HjRAEAgWs5BA (envelope-from ) for ; Thu, 16 Sep 2021 11:43:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6KEVBrMRQ2E0TAAAB5/wlQ (envelope-from ) for ; Thu, 16 Sep 2021 09:43:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61E6814962 for ; Thu, 16 Sep 2021 11:43:14 +0200 (CEST) Received: from localhost ([::1]:57548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQnvF-0004P5-Cx for larch@yhetil.org; Thu, 16 Sep 2021 05:43:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQnv5-0004O9-HD for guix-patches@gnu.org; Thu, 16 Sep 2021 05:43:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQnv5-0007Aa-7f for guix-patches@gnu.org; Thu, 16 Sep 2021 05:43:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQnv5-0008C9-5z for guix-patches@gnu.org; Thu, 16 Sep 2021 05:43:03 -0400 Subject: bug#50428: [PATCH] gnu: Add cryfs Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 16 Sep 2021 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50428 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Brendan Tildesley Cc: 50428-done@debbugs.gnu.org Mail-Followup-To: 50428@debbugs.gnu.org, ludo@gnu.org, mail@brendan.scot Received: via spool by 50428-done@debbugs.gnu.org id=D50428.163178534731421 (code D ref 50428); Thu, 16 Sep 2021 09:43:02 +0000 Received: (at 50428-done) by debbugs.gnu.org; 16 Sep 2021 09:42:27 +0000 Received: from localhost ([127.0.0.1]:53849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQnuV-0008Ah-14 for submit@debbugs.gnu.org; Thu, 16 Sep 2021 05:42:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQnuS-0008AV-O8 for 50428-done@debbugs.gnu.org; Thu, 16 Sep 2021 05:42:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45120) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQnuN-0006bp-7t; Thu, 16 Sep 2021 05:42:19 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=47276 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQnuM-0002fB-V4; Thu, 16 Sep 2021 05:42:19 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20210906133437.3691-1-mail@brendan.scot> (Brendan Tildesley's message of "Mon, 6 Sep 2021 23:34:37 +1000") References: <20210906133437.3691-1-mail@brendan.scot> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Thu, 16 Sep 2021 11:42:17 +0200 Message-ID: <87v93026x2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631785394; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=vR0wJ3Uvpzn8fZqnCvNjazFvDF7uuJI1rLVjXcFmfYg=; b=PNW3GYIH77bmGqeXqZB5iBRBrRU1pmbF77TVhwK3WYwD0mp4jO7staK0KSs1UsG0T5jds9 nV/cWqUBX+jcH/+JRdU1aNDHUFuD7E7jBK/D6jsfGHj4pKwIxUekhW82ZsPqFjwR4hJGik zS8o5TcRkFbXpFYY8OOsMemgNMP4Sdmo4VbSBpaJ6qdaZhmZ350eYYdyTQ7is9ZUGvk+Ku 901aHSvdr7OVbmnRB/I8JO4O3cePgtx3CwlqmtNOaylYHXoxvsJtSt+oIXav3WZE9e24ym HbefSlGNg2X03pgIgZ1ZwUgWgj76jph1eZTRN0rcvAlFMur8ryadBRrOW8Ehtg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631785394; a=rsa-sha256; cv=none; b=KSoa5pqW108kEtsABtQmqar+6tUA36TZOJTppxibFK6h7jPKdb4+wU5VbvWeXEADno1tpC nbR3pwQmyPkp8VbdOANGGfnYgQMO3ZYC0u5UVg/GIRyF1M9zy3r/vJrr4jaQTITHvkWlC/ S+vmwTx/CYZ2KSiZOHYekWWDjdTaOryxVaS3d4rVxsEJVbtJ39UAVwd3JpCAN1/VOqhx2s FrKzexKeGn5BgdWvSkIVTZoqYoq+im38pSDFoEAJaSM/ICEH5GMFdmJpFqPaQHUPfZSwaP PTv0bji+JA4ww79lHzf2thfPb03nMokhx46Z1LLeCRLtoJi+ypqofnnosp3xpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 61E6814962 X-Spam-Score: -2.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2LyByCIBg/FI Hi, Brendan Tildesley skribis: > * gnu/packages/crypto.scm (cryfs): New variable. Overall LGTM modulo the minor issues below: > + '(#:configure-flags > + `("-DCRYFS_UPDATE_CHECKS=3DOFF" ;; Note: This also disables check= ing for security issues. > + "-DCMAKE_BUILD_TYPE=3DRelease" ;; Build man pages. Normally this is set by #:build-type. It defaults to =E2=80=9CRelWithDebIn= fo=E2=80=9D, which is nice because then you get debugging symbols if you pass =E2=80=98--with-debug-info=3Dcryfs=E2=80=99. So I=E2=80=99d suggest removi= ng this second flag. > + (replace 'check > + (lambda* (#:key tests? outputs #:allow-other-keys) > + (use-modules (srfi srfi-1)) Please use #:modules ((srfi srfi-1) =E2=80=A6) instead of this non-top-level =E2=80=98use-modules=E2=80=99 form. > + (when tests? > + (with-directory-excursion "/tmp/build/test" > + (let ((tests (find-files "." "-test$")) > + (tests-output (assoc-ref outputs "tests"))) > + ;; Install tests to a separate output so users can ru= n them. > + (copy-recursively "." tests-output) Installing tests is unusual. Do you really think it=E2=80=99s going to be useful? > + ;; XXX: Disable failing tests. Unfortunately there ar= e a > + ;; few. Some only fail in the build environment. ;; b= uild > + ;; environment. Typo. > + (description "CryFS encrypts your files, so you can safely store the= m anywhere. > + It works well together with cloud services like Dropbox, iCloud, OneDri= ve and ^ Extra space. :-) Could you send an updated patch? Thanks! Ludo=E2=80=99.