[bug#57667] [PATCH] gnu: Add emacs-flymake-collection.

[bug#57667] [PATCH] gnu: Add emacs-flymake-collection.

[jgart via Guix-patches via]

* gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2af9fd945b..2d4f451d8a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1822,6 +1822,27 @@ (define-public emacs-flycheck
 provides an optional IDE-like error list.")
     (license license:gpl3+)))                     ;+GFDLv1.3+ for the manual
 
+(define-public emacs-flymake-collection
+  (package
+    (name "emacs-flymake-collection")
+    (version "20220612.1340")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/flymake-collection-"
+                           version ".tar"))
+       (sha256
+        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/mohkale/flymake-collection/")
+    (synopsis "Collection of checkers for flymake")
+    (description
+"This package tries to provide a comprehensive list of
+diagnostic-functions for use with flymake, give users the tools to
+easily define new syntax checkers and help selectively enable or disable
+diagnostic-functions based on major-modes.")
+    (license license:expat)))
+
 (define-public emacs-flymake-flycheck
   (package
     (name "emacs-flymake-flycheck")
-- 
2.37.3

[bug#57667] [PATCH] gnu: Add emacs-flymake-collection.

[Nicolas Goaziou]

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.

Thanks. Some comments below.

> +(define-public emacs-flymake-collection
> +  (package
> +    (name "emacs-flymake-collection")
> +    (version "20220612.1340")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/flymake-collection-"
> +                           version ".tar"))

We don't fetch tarballs from MELPA because those are not stable. Could
you use Github as upstream instead?

> +       (sha256
> +        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/mohkale/flymake-collection/")
> +    (synopsis "Collection of checkers for flymake")

Nitpick: Flymake

> +    (description
> +"This package tries to provide a comprehensive list of

This package provides…

> +diagnostic-functions for use with flymake, give users the tools to
> +easily define new syntax checkers and help selectively enable or disable
> +diagnostic-functions based on major-modes.")

Nitpick: major modes

Regards,
-- 
Nicolas Goaziou

[bug#57667] [PATCH] gnu: Add emacs-flymake-collection.

[Maxim Cournoyer]

Hi jgart!

Nicolas had done the review below:

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> jgart via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.
>
> Thanks. Some comments below.
>
>> +(define-public emacs-flymake-collection
>> +  (package
>> +    (name "emacs-flymake-collection")
>> +    (version "20220612.1340")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://melpa.org/packages/flymake-collection-"
>> +                           version ".tar"))
>
> We don't fetch tarballs from MELPA because those are not stable. Could
> you use Github as upstream instead?
>
>> +       (sha256
>> +        (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/mohkale/flymake-collection/")
>> +    (synopsis "Collection of checkers for flymake")
>
> Nitpick: Flymake
>
>> +    (description
>> +"This package tries to provide a comprehensive list of
>
> This package provides…
>
>> +diagnostic-functions for use with flymake, give users the tools to
>> +easily define new syntax checkers and help selectively enable or disable
>> +diagnostic-functions based on major-modes.")
>
> Nitpick: major modes

Could you please address the comments and send a v2?

Thank you,

Maxim

[bug#57667] [PATCH] gnu: Add emacs-flymake-collection.

[jgart via Guix-patches via]

On Wed, 28 Sep 2022 14:26:14 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> Could you please address the comments and send a v2?

I'm having an issue building the latest release related to autoloads. I
opened an email thread to talk about it.

I'll look for that and reply again.

bug#57667: [PATCH] gnu: Add emacs-flymake-collection.

[Nicolas Goaziou]

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> On Wed, 28 Sep 2022 14:26:14 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>> Could you please address the comments and send a v2?
>
> I'm having an issue building the latest release related to autoloads. I
> opened an email thread to talk about it.
>
> I'll look for that and reply again.

I went ahead, fixed the package definition and pushed it.

Thank you for the initial work.

Regards,
-- 
Nicolas Goaziou