From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: jgart@dismail.de
Cc: 57667@debbugs.gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: [bug#57667] [PATCH] gnu: Add emacs-flymake-collection.
Date: Wed, 28 Sep 2022 14:26:14 -0400 [thread overview]
Message-ID: <87edvvuzi1.fsf_-_@gmail.com> (raw)
In-Reply-To: <874jxhko25.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 09 Sep 2022 09:24:34 +0200")
Hi jgart!
Nicolas had done the review below:
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> jgart via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-flymake-collection): New variable.
>
> Thanks. Some comments below.
>
>> +(define-public emacs-flymake-collection
>> + (package
>> + (name "emacs-flymake-collection")
>> + (version "20220612.1340")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "https://melpa.org/packages/flymake-collection-"
>> + version ".tar"))
>
> We don't fetch tarballs from MELPA because those are not stable. Could
> you use Github as upstream instead?
>
>> + (sha256
>> + (base32 "1ivf7hqjnpgya6bkn83134yhw6nc29fic642jb73w60j461l2a69"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://github.com/mohkale/flymake-collection/")
>> + (synopsis "Collection of checkers for flymake")
>
> Nitpick: Flymake
>
>> + (description
>> +"This package tries to provide a comprehensive list of
>
> This package provides…
>
>> +diagnostic-functions for use with flymake, give users the tools to
>> +easily define new syntax checkers and help selectively enable or disable
>> +diagnostic-functions based on major-modes.")
>
> Nitpick: major modes
Could you please address the comments and send a v2?
Thank you,
Maxim
next prev parent reply other threads:[~2022-09-28 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 3:49 [bug#57667] [PATCH] gnu: Add emacs-flymake-collection jgart via Guix-patches via
2022-09-09 7:24 ` Nicolas Goaziou
2022-09-28 18:26 ` Maxim Cournoyer [this message]
2022-09-28 20:38 ` jgart via Guix-patches via
2022-10-30 9:55 ` bug#57667: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edvvuzi1.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=57667@debbugs.gnu.org \
--cc=jgart@dismail.de \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).