[bug#68574] [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.

[bug#68574] [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.

[Justin Veilleux]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]


Hi. paperwm was not working. I updated it to v44.17.0 which is the
latest release supporting our version of gnome (42)

Cheers.


[-- Attachment #2: 0001-gnu-gnome-shell-extension-paperwm-Update-to-44.17.0.patch --]
[-- Type: text/x-patch, Size: 2727 bytes --]

From b00fe5137e3df484f3529ef909f7d894ad0e3495 Mon Sep 17 00:00:00 2001
Message-ID: <b00fe5137e3df484f3529ef909f7d894ad0e3495.1705613945.git.terramorpha@cock.li>
From: terramorpha <terramorpha@cock.li>
Date: Thu, 18 Jan 2024 16:36:26 -0500
Subject: [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-paperwm): Update to 44.17.0.

Change-Id: I3d9923ccfdb35b9952c24d8dd3d064c3cba7b8c2
---
 gnu/packages/gnome-xyz.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 6b66658215..399d58ef1b 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2021, 2022 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2021 Songlin Jiang <hollowman@hollowman.ml>
-;;; Copyright © 2021, 2022 Justin Veilleux <terramorpha@cock.li>
+;;; Copyright © 2021, 2022, 2024 Justin Veilleux <terramorpha@cock.li>
 ;;; Copyright © 2021 Attila Lendvai <attila@lendvai.name>
 ;;; Copyright © 2021 Charles Jackson <charles.b.jackson@protonmail.com>
 ;;; Copyright © 2022 Eric Bavier <bavier@posteo.net>
@@ -1016,24 +1016,24 @@ (define-public gnome-shell-extension-noannoyance
 (define-public gnome-shell-extension-paperwm
   (package
     (name "gnome-shell-extension-paperwm")
-    (version "36.0")
+    (version "44.17.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/paperwm/PaperWM")
-                    (commit version)))
+                    (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1ssnabwxrns36c61ppspjkr9i3qifv08pf2jpwl7cjv3pvyn4kly"))
+                "1d91k9qih81wckqf6554kf8grv6q61rkk4g776g0ijpmf35ljdin"))
               (snippet
                '(begin (delete-file "schemas/gschemas.compiled")))))
     (build-system copy-build-system)
     (arguments
      '(#:install-plan
-       '(("." "share/gnome-shell/extensions/paperwm@hedning:matrix.org"
+       '(("." "share/gnome-shell/extensions/paperwm@paperwm.github.com"
           #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
-                            "\\.xml$" "\\.compiled$")))
+                            "\\.xml$" "\\.compiled$" "\\.svg$")))
        #:phases
        (modify-phases %standard-phases
          (add-before 'install 'compile-schemas

base-commit: 3e3975275bbab84d58f7740e9680b265769aa580
-- 
2.41.0

[bug#68574] [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.

[Vivien Kraus via Guix-patches via]

Hello!

Thank you for your patch! How convenient, 44.17.0 is also the latest
version that works on GNOME 44, which is being worked on over at
https://issues.guix.gnu.org/68556

Since you update the package, maybe it could be the right time to
update the packaging style also. There are 3 things that you could
change:

- convert the 'arguments field to a list of G-Expressions;
- remove the #t at the end of the 'compile-schemas phase;
- remove the package label in native-inputs.

Aside from that, I see no problem with your patch.

Best regards,

Vivien

[bug#68574] [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.

[Justin Veilleux]

[-- Attachment #1: Type: text/plain, Size: 60 bytes --]


Hello. Thanks for the feedback! Here is an updated patch.


[-- Attachment #2: 0001-gnu-gnome-shell-extension-paperwm-Update-to-44.17.0.patch --]
[-- Type: text/x-patch, Size: 3501 bytes --]

From 3336aef64ce5e47e1a71aee1d84919d2ae56abbe Mon Sep 17 00:00:00 2001
Message-ID: <3336aef64ce5e47e1a71aee1d84919d2ae56abbe.1705814798.git.terramorpha@cock.li>
From: terramorpha <terramorpha@cock.li>
Date: Thu, 18 Jan 2024 16:36:26 -0500
Subject: [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-paperwm): Update to 44.17.0.
---
 gnu/packages/gnome-xyz.scm | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 6b66658215..568ee7343e 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2021, 2022 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2021 Songlin Jiang <hollowman@hollowman.ml>
-;;; Copyright © 2021, 2022 Justin Veilleux <terramorpha@cock.li>
+;;; Copyright © 2021, 2022, 2024 Justin Veilleux <terramorpha@cock.li>
 ;;; Copyright © 2021 Attila Lendvai <attila@lendvai.name>
 ;;; Copyright © 2021 Charles Jackson <charles.b.jackson@protonmail.com>
 ;;; Copyright © 2022 Eric Bavier <bavier@posteo.net>
@@ -1016,33 +1016,33 @@ (define-public gnome-shell-extension-noannoyance
 (define-public gnome-shell-extension-paperwm
   (package
     (name "gnome-shell-extension-paperwm")
-    (version "36.0")
+    (version "44.17.0")
     (source (origin
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/paperwm/PaperWM")
-                    (commit version)))
+                    (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1ssnabwxrns36c61ppspjkr9i3qifv08pf2jpwl7cjv3pvyn4kly"))
+                "1d91k9qih81wckqf6554kf8grv6q61rkk4g776g0ijpmf35ljdin"))
               (snippet
                '(begin (delete-file "schemas/gschemas.compiled")))))
     (build-system copy-build-system)
     (arguments
-     '(#:install-plan
-       '(("." "share/gnome-shell/extensions/paperwm@hedning:matrix.org"
-          #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
-                            "\\.xml$" "\\.compiled$")))
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'install 'compile-schemas
-           (lambda _
-             (with-directory-excursion "schemas"
-               (invoke "make"))
-             #t)))))
+     (list
+      #:install-plan
+      #~'(("." "share/gnome-shell/extensions/paperwm@paperwm.github.com"
+           #:include-regexp ("\\.js(on)?$" "\\.css$" "\\.ui$" "\\.png$"
+                             "\\.xml$" "\\.compiled$" "\\.svg$")))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install 'compile-schemas
+            (lambda _
+              (with-directory-excursion "schemas"
+                (invoke "make")))))))
     (native-inputs
-     `(("glib:bin" ,glib "bin"))) ; for glib-compile-schemas
+     `((,glib "bin"))) ; for glib-compile-schemas
     (home-page "https://github.com/paperwm/PaperWM")
     (synopsis "Tiled scrollable window management for GNOME Shell")
     (description "PaperWM is an experimental GNOME Shell extension providing

base-commit: 3e3975275bbab84d58f7740e9680b265769aa580
-- 
2.41.0

bug#68574: [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.

[Liliana Marie Prikler]

Hi,

Am Samstag, dem 20.01.2024 um 00:22 +0100 schrieb Vivien Kraus:
> Hello!
> 
> Thank you for your patch! How convenient, 44.17.0 is also the latest
> version that works on GNOME 44, which is being worked on over at
> https://issues.guix.gnu.org/68556
> 
> Since you update the package, maybe it could be the right time to
> update the packaging style also. There are 3 things that you could
> change:
> 
> - convert the 'arguments field to a list of G-Expressions;
> - remove the #t at the end of the 'compile-schemas phase;
> - remove the package label in native-inputs.
> 
> Aside from that, I see no problem with your patch.
I've pushed the original version, followed by a style update that
incorporates both of your fixes.  I hope that's fine.

Cheers