From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>, 68574-done@debbugs.gnu.org
Subject: bug#68574: [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0.
Date: Sun, 21 Jan 2024 09:50:55 +0100 [thread overview]
Message-ID: <6da2b76c0bc7a2832bc276def4fc2d12f745dc45.camel@gmail.com> (raw)
In-Reply-To: <1957dda76ba12f5febb747d6dfa3d7be08a5d69b.camel@planete-kraus.eu>
Hi,
Am Samstag, dem 20.01.2024 um 00:22 +0100 schrieb Vivien Kraus:
> Hello!
>
> Thank you for your patch! How convenient, 44.17.0 is also the latest
> version that works on GNOME 44, which is being worked on over at
> https://issues.guix.gnu.org/68556
>
> Since you update the package, maybe it could be the right time to
> update the packaging style also. There are 3 things that you could
> change:
>
> - convert the 'arguments field to a list of G-Expressions;
> - remove the #t at the end of the 'compile-schemas phase;
> - remove the package label in native-inputs.
>
> Aside from that, I see no problem with your patch.
I've pushed the original version, followed by a style update that
incorporates both of your fixes. I hope that's fine.
Cheers
prev parent reply other threads:[~2024-01-21 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 21:41 [bug#68574] [PATCH] gnu: gnome-shell-extension-paperwm: Update to 44.17.0 Justin Veilleux
2024-01-19 23:22 ` Vivien Kraus via Guix-patches via
2024-01-21 5:34 ` Justin Veilleux
2024-01-21 8:50 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da2b76c0bc7a2832bc276def4fc2d12f745dc45.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=68574-done@debbugs.gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).