From: "Ludovic Courtès" <ludo@gnu.org>
To: Steve George <steve@futurile.net>
Cc: nicolas.debonnaire@gmail.com, 67257@debbugs.gnu.org
Subject: [bug#67257] [PATCH v2 1/2] gnu: Add nx-libs.
Date: Tue, 27 Feb 2024 10:59:14 +0100 [thread overview]
Message-ID: <87sf1ei5xp.fsf@gnu.org> (raw)
In-Reply-To: <834a3cc5e7e16f94691c1bb726f1dd1cc5edb6d0.1708638616.git.steve@futurile.net> (Steve George's message of "Thu, 22 Feb 2024 22:08:19 +0000")
Hi!
Thank you Steve for shepherding this patch set! Here are some comments
on minor issues.
Steve George <steve@futurile.net> skribis:
> From: nicodebo <nicolas.debonnaire@gmail.com>
>
> * gnu/packages/nx.scm: New file.
> * gnu/packages/nx.scm (nx-libs): New variable.
The second line is unnecessary.
Please make sure to add the file to ‘gnu/local.mk’.
> +++ b/gnu/packages/nx.scm
> @@ -0,0 +1,141 @@
> +;;; This file is part of GNU Guix.
Looks like a couple of lines are missing from the usual header.
> + (add-before 'build 'replace-shebang-nxdialog
> + (lambda _
> + (substitute* "nxdialog/bin/nxdialog"
> + (("#!/usr/bin/env python")
> + (string-append "#!"
> + (which "python3"))))))
‘which’ returns ‘python3’ as found in $PATH—i.e., the native python.
To do the right thing in a cross-compilation context (for example, pick
the AArch64 ‘python3’ binary if you’re cross-compiling to AArch64), it
should be written like this:
(lambda* (#:key inputs #:allow-other-keys)
(substitute* …
(… … (search-input-file inputs "/bin/python3"))))
> + (synopsis "NX remote desktop library")
> + (description
> + "NX technology also known as NX or NoMachine is a protocol that enables
> +remote desktop access. It's maintained by the artica project, x2go
> +developers and TheQVD.")
Please describe that the package does; who maintains it is usually not
relevant here:
https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
Thanks,
Ludo’.
next prev parent reply other threads:[~2024-02-27 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 18:46 [bug#67257] [PATCH 0/2] add x2goclient nicodebo
2023-11-18 7:59 ` [bug#67257] [PATCH 1/2] Add nx-libs nicodebo
2023-11-18 7:59 ` [bug#67257] [PATCH 2/2] Add x2goclient nicodebo
2024-02-22 22:08 ` [bug#67257] [PATCH v2 0/2] re: add x2goclient and nx-libs Steve George
2024-02-22 22:08 ` [bug#67257] [PATCH v2 1/2] gnu: Add nx-libs Steve George
2024-02-27 9:59 ` Ludovic Courtès [this message]
2024-03-10 0:40 ` Maxim Cournoyer
2024-02-22 22:08 ` [bug#67257] [PATCH v2 2/2] gnu: Add x2goclient Steve George
2024-02-27 10:02 ` Ludovic Courtès
2024-03-10 0:45 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf1ei5xp.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=67257@debbugs.gnu.org \
--cc=nicolas.debonnaire@gmail.com \
--cc=steve@futurile.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).